Fix dark mode issues with new color system #2105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Fix broken dark mode on some UIKit screens.
There's some subtle misbehavior when creating a
UIColor
from aColor
whose value is defined by a color resolver. It's likely an Apple bug, but to work around it in the meantime, this reverts back to the 0.30 and earlier behavior of storing raw color data asDynamicColor
values.Binary change
Coming soon!
Verification
Ensured light and dark modes all function as expected in both UIKit and SwiftUI.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow