Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add FocusAsync methods to FluentInputBase #191

Merged
merged 2 commits into from
May 27, 2022

Conversation

williamw2
Copy link
Contributor

@williamw2 williamw2 commented May 25, 2022

Pull Request

📖 Description

Add FocusAsync methods to FluentInputBase and give examples in the TextField, NumberField and TextArea pages.

This PR exposes the ElementReference.FocusAsync() methods of the underlying element encapsulated by the FluentInputBase derived components. This makes it easier to programmatically set the focus on text based input fields.

🎫 Issues

closes #157

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@williamw2 williamw2 self-assigned this May 25, 2022
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-191.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-191.centralus.azurestaticapps.net

Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great addition!

@williamw2 williamw2 merged commit 0d41771 into main May 27, 2022
@williamw2 williamw2 deleted the users/williamw2/AddFocusAsyncToFluentInputBase branch May 27, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to focus a Fluent component
3 participants