Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events #198

Merged
merged 12 commits into from
Jul 15, 2022
Merged

Events #198

merged 12 commits into from
Jul 15, 2022

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Jun 21, 2022 •
edited
Loading

Pull Request

📖 Description

This PR adds extra event handling and associated code. Blazor components with new event handling are:

Component Event name Arguments
<FluentTabs> ontabchange TabChangeEventArgs
<FluentTreeView> onselectedchange TreeChangeEventArgs
<FluentTreeView> onexpandedchange TreeChangeEventArgs
<FluentCalendar> ondateselected CalendarSelectEventArgs
<FluentAccordion>* onaccordionchange AccordionChangeEventArgs
<FluentDialog> ondismiss -
<FluentTooltip> ondismiss -
<FluentMenu> onmenuchange -
<FluentHorizontalScroll> onscrollstart HorizontalScrollEventArgs
<FluentHorizontalScroll> onscrollend HorizontalScrollEventArgs
<FluentDataGridCell> oncellfocused DataGridCellFocusedEventArgs
<FluentDataGridRow> onrowfocused DataGridRowFocusedEventArgs
<FluentSearch> onchange ChangeEventArgs

With these events in place, you can now have more bindings:

  • <FluentAccordion>* : Bind the ActiveId parameter to the id of the active accordion item
  • <FluentTabs> : Bind the ActiveId parameter to the id of the active tab
  • <FluentTreeView> : Bind the CurrentSelected parameter to the id of currently selected tree item
  • <FluentTreeView> : Bind the CurrentExpanded parameter to the id of the last expanded/collapsed tree item
  • <FluentCalendar> : Bind the SelectedDates parameter to the List<DateOnly> of selected dates
  • = not implemented yet. We are waiting for the necessary changes in the web components script.

Other changes:

  • Add Disabled and Text parameters to <FluentTab>
  • Add Heading parameter to <FluentAccordionItem>
  • Add Text parameter to <FluentTreeItem>
  • Fix ActiveIndicator parameter on <FluentTabs>
  • Add DisabledSelectable parameter to <FluentCalendar> (defaults to true)
  • Add OutOfMonthSelectable parameter to <FluentCalendar> (defaults to true)
  • Add <FluentNumberFieldOnInput> component as an example of how to create this behavior

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@vnbaaij vnbaaij marked this pull request as draft June 21, 2022 07:56
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

5 similar comments
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@vnbaaij vnbaaij mentioned this pull request Jun 24, 2022
Merged
6 tasks
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@vnbaaij vnbaaij mentioned this pull request Jul 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@vnbaaij vnbaaij removed the request for review from nicholasrice July 14, 2022 12:04
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@vnbaaij vnbaaij marked this pull request as ready for review July 14, 2022 12:04
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-cliff-0c0c93310-198.centralus.azurestaticapps.net

@vnbaaij vnbaaij merged commit cb72855 into main Jul 15, 2022
@vnbaaij vnbaaij deleted the events branch July 15, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamw2 williamw2 williamw2 approved these changes

@EisenbergEffect EisenbergEffect Awaiting requested review from EisenbergEffect

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnbaaij @williamw2