-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Overflow] Add refresh method, add VisibleOnLoad parameter #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vnbaaij
commented
Jun 20, 2024
•
edited
Loading
edited
- Rename functions in js to be in line with rest of scripts
- Add public RefreshAsync method to call refresh function in script (fix: FluentOverflow does not fit to container when ChildContent is modified #2225)
- Add VisibleOnLoad parameter (fix: FluentOverflow initially paints and then repaints if an overflow is detected, leading to a flash in FluentOverflow #2224)
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.4%
|
dvoituron
requested changes
Jun 20, 2024
vnbaaij
changed the title
[Overflow] Add refresh method (+ maybe add new parameter)
[Overflow] Add refresh method, add VisibleOnLoad parameter
Jun 22, 2024
- Add VisiblieOnLoad parameter - Add compensation for overflow badge itself in js
…osoft/fluentui-blazor into users/vnbaaij/overflow-work
dvoituron
requested changes
Jun 22, 2024
dvoituron
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.