Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fixes link for Time picker in demo projects #2246

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[Demo] Fixes link for Time picker in demo projects #2246

merged 3 commits into from
Jun 24, 2024

Conversation

MarvinKlein1508
Copy link
Contributor

Pull Request

📖 Description

this PR removes the fragment from the demo navigation for the /DateTime link.

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the fragment should be removed. It just needs to point to the default time picker example on that page.

@MarvinKlein1508
Copy link
Contributor Author

@vnbaaij I removed it since all other components don't have one as well. It would be strange to start the page right in the middle since there is no nav item for FluentDatePicker

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 24, 2024

Yes, it is strange but even stranger to click on a link to time picker and land on a date picker segment 😀.

Time picker is an InputBase derived component. That is why it is shown in Form and input menu. DatePicker is not InputBase derived (yet?).

We need to address the underlying issue and probably just make separate pages.

@MarvinKlein1508
Copy link
Contributor Author

Got it. Added the fragment. I didn't even know that you can find the FluentDatePicker under components instead.

@vnbaaij vnbaaij self-requested a review June 24, 2024 05:51
@vnbaaij vnbaaij enabled auto-merge (squash) June 24, 2024 05:52
@vnbaaij vnbaaij merged commit c6cdfbf into microsoft:dev Jun 24, 2024
2 checks passed
@vnbaaij vnbaaij added this to the v4.8.2 milestone Jun 25, 2024
@MarvinKlein1508 MarvinKlein1508 deleted the fix-nav branch June 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants