Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox] Set value if selection is cleared #2307

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

joriverm
Copy link
Contributor

@joriverm joriverm commented Jul 2, 2024

Pull Request

πŸ“– Description

this fixes #2302 , but is uncertain if it breaks anything again as the null coalesce might have been removed for a reason?

🎫 Issues

#2302

πŸ‘©β€πŸ’» Reviewer Notes

@vnbaaij , this is the fix i was talking about. Ive also added a unit test while i was at it

πŸ“‘ Test Plan

Unit tests were added, but can also be tested by adding the code specified in the issue

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

N/A

@joriverm
Copy link
Contributor Author

joriverm commented Jul 2, 2024

@microsoft-github-policy-service agree

@vnbaaij vnbaaij changed the title Combobox: set value if selection is cleared [Combobox] Set value if selection is cleared Jul 2, 2024
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jul 2, 2024

I do not recall why the string.Empty was commented. I tried the PR change with the different combobox issues mentioned and they all work as they should still/now.

@vnbaaij vnbaaij merged commit 292c7f4 into microsoft:dev Jul 2, 2024
2 checks passed
@joriverm joriverm deleted the fixes/clearCombobox branch July 2, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: clear selection in FluentCombobox
2 participants