[Dialog] Make dismiss button larger and use neutral color #2565

vnbaaij · 2024-08-21T17:52:46Z

In accordance with the React and v3 Web Components, the dismiss icon has been enlarged to 20px (from 16px) and the color has been changed to neutral (instead of accent)

Before

After

- Change dismiss icon color

github-actions · 2024-08-21T17:56:00Z

✅ All tests passed successfully

Details on your Workflow / Core Tests page.

github-actions · 2024-08-21T17:56:00Z

Unit Tests

❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogServiceTests.FluentDialogService_Default
❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Checkbox.FluentCheckboxThreeStatesTests.FluentCheckbox_ThreeStatesFalseAsync(initialValue: False, assertValue: True)
❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Checkbox.FluentCheckboxThreeStatesTests.FluentCheckbox_ThreeStatesFalseAsync(initialValue: True, assertValue: False)
❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogTests.FluentDialog_HeaderFooter
❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogServiceTests.FluentDialog_RenderFragment
❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogServiceTests.FluentDialogService_HeightUnset

Details on your Workflow / Core Tests page.

dvoituron · 2024-08-21T18:16:13Z

@vnbaaij Have you noticed that several unit tests are failing?

vnbaaij · 2024-08-21T18:19:14Z

@vnbaaij Have you noticed that several unit tests are failing?

Yes, working on that

…ui-blazor into fix-issue-#2539

github-actions · 2024-08-21T19:27:05Z

Summary - Unit Tests Code Coverage

Summary


Generated on:	8/21/2024 - 8:58:29 PM
Coverage date:	8/21/2024 - 8:58:23 PM
Parser:	Cobertura
Assemblies:	1
Classes:	241
Files:	339
Line coverage:	61.2% (5277 of 8622)
Covered lines:	5277
Uncovered lines:	3345
Coverable lines:	8622
Total lines:	29352
Branch coverage:	52.7% (2571 of 4871)
Covered branches:	2571
Total branches:	4871
Method coverage:	Feature is only available for sponsors
Tag:	1279_10497348172

Coverage

Microsoft.FluentUI.AspNetCore.Components - 61.2%

Name	Line	Branch
Microsoft.FluentUI.AspNetCore.Components	61.2%	52.7%
Microsoft.FluentUI.AspNetCore.Components.AccordionChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.ActionButton`1	50%
Microsoft.FluentUI.AspNetCore.Components.ActionLink`1	0%
Microsoft.FluentUI.AspNetCore.Components.CalendarExtended	95%	86.6%
Microsoft.FluentUI.AspNetCore.Components.CalendarTitles	87%	76.6%
Microsoft.FluentUI.AspNetCore.Components.CheckboxChangeEventArgs	50%
Microsoft.FluentUI.AspNetCore.Components.ColumnBase`1	53.5%	22.5%
Microsoft.FluentUI.AspNetCore.Components.ColumnResizeOptions`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.ComponentParameters	16.6%	0%
Microsoft.FluentUI.AspNetCore.Components.Components.DateTime.RangeOfDates	100%	50%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipGlobalOp tions	40%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipOptions	100%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipService	72.5%	50%
Microsoft.FluentUI.AspNetCore.Components.CountdownTimer	0%	0%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.AsyncQuery ExecutorSupplier	72.7%	71.4%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.ColumnsCol lectedNotifier`1	87.5%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.Defer	100%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.DisplayAtt ributeExtensions	66.6%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGr idContext`1	90.9%	100%
Microsoft.FluentUI.AspNetCore.Components.DataGridCellFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DataGridRowFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogInstance	92.3%	75%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters	92.3%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters`1	100%
Microsoft.FluentUI.AspNetCore.Components.DialogReference	36.3%	37.5%
Microsoft.FluentUI.AspNetCore.Components.DialogResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.DialogService	4.1%	3.3%
Microsoft.FluentUI.AspNetCore.Components.Emoji	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiCompress	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiInfo	0%
Microsoft.FluentUI.AspNetCore.Components.Extensions.AdditionalAttributesExt ensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.BooleanExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.DateTimeExtensions	82.5%	85%
Microsoft.FluentUI.AspNetCore.Components.Extensions.EnumExtensions	70.5%	59%
Microsoft.FluentUI.AspNetCore.Components.Extensions.FluentInputExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Extensions.UrlFormatterExtensions	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentAccessibilityStatus	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordion	60%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem	76%	35.7%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchor	89.7%	67.8%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchoredRegion	87.5%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBar	53.7%	35.2%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBarItem	82.1%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentAutocomplete`1	87.9%	76.4%
Microsoft.FluentUI.AspNetCore.Components.FluentBadge	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBodyContent	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumb	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumbItem	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentButton	84.6%	64%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendar	89%	82.6%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarBase	93.3%	81.2%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarDay	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarMonth	100%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarYear	90.9%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentCard	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCheckbox	90.7%	87%
Microsoft.FluentUI.AspNetCore.Components.FluentCollapsibleRegion	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCombobox`1	81.8%	70%
Microsoft.FluentUI.AspNetCore.Components.FluentComponentBase	90.9%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentCounterBadge	93.1%	86.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1	61.3%	45.7%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridCell`1	72%	37.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridRow`1	57.6%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentDatePicker	72%	45%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignSystemProvider	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignTheme	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDialog	62.5%	71%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogBody	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogFooter	62.5%	43.3%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogHeader	80.9%	81.8%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogProvider	59.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentDivider	86.3%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDragContainer`1	69.2%
Microsoft.FluentUI.AspNetCore.Components.FluentDragEventArgs`1	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDropZone`1	20%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentEditForm	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentEmoji`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentFlipper	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFooter	100%
Microsoft.FluentUI.AspNetCore.Components.FluentGrid	71.4%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentGridItem	87.2%	82.5%
Microsoft.FluentUI.AspNetCore.Components.FluentHeader	100%
Microsoft.FluentUI.AspNetCore.Components.FluentHighlighter	92.3%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentHorizontalScroll	59.3%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentIcon`1	87.8%	80.4%
Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1	70%	61%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFile	88.4%	76.6%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileBuffer	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileEventArgs	91.6%
Microsoft.FluentUI.AspNetCore.Components.FluentInputLabel	100%	95%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCode	90.1%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeEventArgs	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeProvider	40%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentLabel	72.7%	21.4%
Microsoft.FluentUI.AspNetCore.Components.FluentLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentListbox`1	93.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentMain	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMainLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMenu	36.4%	40.7%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuButton	70.2%	8.3%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuItem	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBar	54.1%	25%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBarProvider	82.3%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitter	81.7%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterPane	97.1%	91%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterResizeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentNavBase	55.1%	16.6%
Microsoft.FluentUI.AspNetCore.Components.FluentNavGroup	62.1%	36.6%
Microsoft.FluentUI.AspNetCore.Components.FluentNavLink	86.3%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenu	59.6%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuGroup	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuItemBase	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuLink	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuTree	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1	64.4%	47.9%
Microsoft.FluentUI.AspNetCore.Components.FluentOption`1	78.9%	58.3%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflow	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverlay	70%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentPageScript	100%
Microsoft.FluentUI.AspNetCore.Components.FluentPaginator	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentPersona	100%	78.1%
Microsoft.FluentUI.AspNetCore.Components.FluentPopover	77%	65.9%
Microsoft.FluentUI.AspNetCore.Components.FluentPresenceBadge	60.3%	29.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProfileMenu	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProgress	85.7%	68.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProgressRing	97.4%	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentPullToRefresh	93.9%	89.2%
Microsoft.FluentUI.AspNetCore.Components.FluentRadio`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioContext	70%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioGroup`1	83.3%	28.5%
Microsoft.FluentUI.AspNetCore.Components.FluentRating	82.6%	84.2%
Microsoft.FluentUI.AspNetCore.Components.FluentSearch	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSelect`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSkeleton	42.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSlider`1	60%	27.7%
Microsoft.FluentUI.AspNetCore.Components.FluentSliderLabel`1	63.1%	30%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableList`1	80%	59%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableListEventArgs	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentSpacer	100%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSplashScreen	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSplitter	68.4%	40%
Microsoft.FluentUI.AspNetCore.Components.FluentStack	90.2%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentSwitch	88.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentTab	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTabs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTextArea	84.2%
Microsoft.FluentUI.AspNetCore.Components.FluentTextField	88.5%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentTimePicker	100%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToastProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToolbar	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltip	88.8%	64.2%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltipProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeItem	85.3%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeView	91.3%	84.3%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationMessage`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationSummary	100%	87.5%
Microsoft.FluentUI.AspNetCore.Components.FluentWizard	93.1%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStep	97%	88.3%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.GlobalState	33.3%	50%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderRequest`1	92.3%	41.6%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult`1	100%
Microsoft.FluentUI.AspNetCore.Components.GridSort`1	35.1%	25.9%
Microsoft.FluentUI.AspNetCore.Components.HorizontalScrollEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.Icon	81.3%	85.2%
Microsoft.FluentUI.AspNetCore.Components.IconFromImage	100%
Microsoft.FluentUI.AspNetCore.Components.IconInfo	100%
Microsoft.FluentUI.AspNetCore.Components.Identifier	66.6%	62.5%
Microsoft.FluentUI.AspNetCore.Components.IdentifierContext	66.6%	41.6%
Microsoft.FluentUI.AspNetCore.Components.INavMenuItemsOwner	0%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr ibable`1	83.3%	100%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr iber`1	90%	75%
Microsoft.FluentUI.AspNetCore.Components.InputHelpers`1	36.9%	31.2%
Microsoft.FluentUI.AspNetCore.Components.InternalAppBarContext	100%	100%
Microsoft.FluentUI.AspNetCore.Components.InternalDialogContext	80%
Microsoft.FluentUI.AspNetCore.Components.InternalListContext`1	80%	66.6%
Microsoft.FluentUI.AspNetCore.Components.InternalToastContext	0%
Microsoft.FluentUI.AspNetCore.Components.KeyCodeService	60.3%	28.5%
Microsoft.FluentUI.AspNetCore.Components.LibraryConfiguration	88.2%	50%
Microsoft.FluentUI.AspNetCore.Components.ListComponentBase`1	62.7%	59.5%
Microsoft.FluentUI.AspNetCore.Components.LoadedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.LuminanceChangedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.MenuChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.MenuService	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Message	50%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBox	66.6%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBoxContent	0%
Microsoft.FluentUI.AspNetCore.Components.MessageOptions	76.9%
Microsoft.FluentUI.AspNetCore.Components.MessageService	33%	26.9%
Microsoft.FluentUI.AspNetCore.Components.NavMenuActionArgs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.OfficeColorUtilities	0%
Microsoft.FluentUI.AspNetCore.Components.Option`1	0%
Microsoft.FluentUI.AspNetCore.Components.OptionsSearchEventArgs`1	100%
Microsoft.FluentUI.AspNetCore.Components.OverflowItem	100%
Microsoft.FluentUI.AspNetCore.Components.PaginationState	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ProgressFileDetails	100%
Microsoft.FluentUI.AspNetCore.Components.ProgressToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ProgressToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.PropertyColumn`2	80%	52.6%
Microsoft.FluentUI.AspNetCore.Components.RenderFragmentDialog	100%
Microsoft.FluentUI.AspNetCore.Components.Resources.TimeAgoResource	76.1%	100%
Microsoft.FluentUI.AspNetCore.Components.SelectAllTemplateArgs	100%
Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1	85.9%	79.4%
Microsoft.FluentUI.AspNetCore.Components.SelectDatesHoverEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.ServiceCollectionExtensions	80%	100%
Microsoft.FluentUI.AspNetCore.Components.SortedProperty	0%
Microsoft.FluentUI.AspNetCore.Components.SplashScreenContent	0%	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterCollapsedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterResizedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.StandardLuminanceExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.StaticAssetServiceConfiguration	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TabChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.TemplateColumn`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TimeAgoOptions	92.3%
Microsoft.FluentUI.AspNetCore.Components.ToastInstance	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters`1	0%
Microsoft.FluentUI.AspNetCore.Components.ToastResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastService	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TreeChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItem	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItemExpandedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.UploadedFileDetails	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.CssBuilder	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Debouncer	94.8%	37.5%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InlineStyleBuilder	96.4%	87.5%
Microsoft.FluentUI.AspNetCore.Components.Utilities.JSModule	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.RangeOf`1	96.7%	94.4%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Splitter	82.8%	81.8%
Microsoft.FluentUI.AspNetCore.Components.Utilities.StyleBuilder	100%	91.6%
Microsoft.FluentUI.AspNetCore.Components.ZIndex	100%
System.Text.RegularExpressions.Generated	76.6%	51.4%

dvoituron · 2024-08-21T19:41:15Z

tests/Core/Checkbox/FluentCheckboxThreeStatesTests.razor

-                ThreeState="false"
-                @bind-Value="@myValue" />
-        );
+    // Temporarily disable this test until we figure out how why the delay in checkbox breaks this


That's not a good idea :-)
Can you create another PR to fix that?

I know what is causing the issue. Need to take a look at it with you when you are back. Won't be forgotten!

…2565) * - Make dialog header dismiss button a bit larger - Change dismiss icon color * Update tests * Temp disable one test

- Make dialog header dismiss button a bit larger

4b4cdaf

- Change dismiss icon color

vnbaaij requested a review from dvoituron as a code owner August 21, 2024 17:52

vnbaaij changed the title ~~[Dialog] Make dismiss button larger~~ [Dialog] Make dismiss button larger and use neutral color Aug 21, 2024

Merge branch 'dev' into fix-issue-#2539

1801ffd

vnbaaij added 2 commits August 21, 2024 20:05

Update tests

a785021

Merge branch 'dev' into fix-issue-#2539

53e33f1

vnbaaij added 2 commits August 21, 2024 21:23

Temp disable one test

50a0ebe

Merge branch 'fix-issue-#2539' of https://github.com/microsoft/fluent…

f0990b4

…ui-blazor into fix-issue-#2539

vnbaaij enabled auto-merge (squash) August 21, 2024 19:24

dvoituron reviewed Aug 21, 2024

View reviewed changes

vnbaaij disabled auto-merge August 21, 2024 20:55

vnbaaij merged commit 621aa4e into dev Aug 21, 2024
5 checks passed

vnbaaij deleted the fix-issue-#2539 branch August 21, 2024 20:55

vnbaaij added this to the v4.9.4 milestone Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dialog] Make dismiss button larger and use neutral color #2565

[Dialog] Make dismiss button larger and use neutral color #2565

vnbaaij commented Aug 21, 2024

github-actions bot commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024

dvoituron commented Aug 21, 2024

vnbaaij commented Aug 21, 2024

github-actions bot commented Aug 21, 2024 •

edited

Loading

dvoituron Aug 21, 2024

vnbaaij Aug 21, 2024

[Dialog] Make dismiss button larger and use neutral color #2565

[Dialog] Make dismiss button larger and use neutral color #2565

Conversation

vnbaaij commented Aug 21, 2024

Before

After

github-actions bot commented Aug 21, 2024 • edited Loading

github-actions bot commented Aug 21, 2024

Unit Tests

dvoituron commented Aug 21, 2024

vnbaaij commented Aug 21, 2024

github-actions bot commented Aug 21, 2024 • edited Loading

Summary - Unit Tests Code Coverage

Coverage

dvoituron Aug 21, 2024

Choose a reason for hiding this comment

vnbaaij Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024 •

edited

Loading