Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluentInputBase] Force EditContext to be re-associated with the Dispatcher #2620

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

cduluCNB
Copy link
Contributor

@cduluCNB cduluCNB commented Sep 5, 2024

Pull Request

📖 Description

Change notification call to use InvokeAsync to bring back the EditContext into the same thread as the dispatcher.

More details here: #2466 (comment)

🎫 Issues

Fix #2466: Dispatcher Exception in Debouncer 4.8.x+

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@cduluCNB cduluCNB marked this pull request as ready for review September 5, 2024 15:47
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical. Especially considering we are doing the same in the other brach of this if... then

@vnbaaij vnbaaij changed the title [FluentInputBase] Fix #2466 Force EditContext to be re-associated with the Dispatcher [FluentInputBase] Force EditContext to be re-associated with the Dispatcher Sep 5, 2024
@vnbaaij vnbaaij merged commit 406d3fc into microsoft:dev Sep 6, 2024
4 checks passed
@cduluCNB
Copy link
Contributor Author

cduluCNB commented Sep 6, 2024

Thank you!

dannyldj pushed a commit to dannyldj/fluentui-blazor that referenced this pull request Sep 26, 2024
…spatcher (microsoft#2620)

Co-authored-by: Vincent Baaij <vnbaaij@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Dispatcher Exception in Debouncer 4.8.x+
2 participants