Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [FluentNavLink] An issue where empty strings were not allowed in Href #2722

Merged
merged 4 commits into from
Sep 28, 2024
Merged

fix: [FluentNavLink] An issue where empty strings were not allowed in Href #2722

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5542ccd
fix: [FluentNavLink] An issue where empty strings were not allowed in…
dannyldj Sep 26, 2024
1fbf246
Merge branch 'dev' into fix/FluentNavLink
dannyldj Sep 26, 2024
dc90234
Merge branch 'dev' into fix/FluentNavLink
vnbaaij Sep 26, 2024
de0d01b
Merge branch 'dev' into fix/FluentNavLink
vnbaaij Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/Components/NavMenu/FluentNavLink.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@if (Owner == null || Owner.Expanded || (HasIcon && (!Owner.CollapsedChildNavigation || SubMenu == null)))
{
<div id="@Id" @attributes="AdditionalAttributes" class="@ClassValue" disabled="@Disabled" style="@Style" role="menuitem">
@if (!OnClick.HasDelegate && !string.IsNullOrEmpty(Href))
@if (!OnClick.HasDelegate && Href is not null)
{
<NavLink class="@LinkClassValue"
@attributes="@Attributes"
Expand Down
Loading