Skip to content

Commit

Permalink
PR 15550: Move React to devDep and peerDep.
Browse files Browse the repository at this point in the history
- Move React to devDep and peerDep. Reference: http://stackoverflow.com/a/30454133/1436671
- Release the React semver restriction to 0.14.x.
- The peer dependency leaves the App to resolve the React dependencies.
- It is a MUST to do so, we cannot guarantee the App is using webpack and leverage dedup.
- If not dedup and two React copies run in the page, it leads problems. Like this: facebook/react#1939
- Follow reading the React new version schema: http://facebook.github.io/react/blog/2016/02/19/new-versioning-scheme.html
  • Loading branch information
lijunle committed Mar 25, 2016
2 parents d235f85 + a762839 commit 00ee895
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ms/office-ui-fabric-react",
"version": "0.1.3",
"version": "0.1.4",
"description": "This is a repo for building out React controls skinned with Fabric.",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand All @@ -19,16 +19,20 @@
"highlight.js": "^8.4.0",
"lodash.merge": "^4.3.2",
"office-ui-fabric": "^2.0.1",
"react": "^0.14.7",
"react-addons-test-utils": "^0.14.3",
"react-dom": "^0.14.7",
"react-highlight": "^0.6.1",
"vinyl-ftp": "^0.4.5",
"web-library-build": "0.0.12",
"webpack-notifier": "^1.2.1",
"webpack-split-by-path": "0.0.8"
},
"dependencies": {
"load-themed-styles": "^1.0.3",
"react": "^0.14.7",
"react-dom": "^0.14.7"
"load-themed-styles": "^1.0.3"
},
"peerDependencies": {
"react": "^0.14.0",
"react-dom": "^0.14.0"
}
}

0 comments on commit 00ee895

Please sign in to comment.