Skip to content

Commit

Permalink
chore: wc-3 changes necessary in order to bring it back to master (#3…
Browse files Browse the repository at this point in the history
  • Loading branch information
Hotell authored May 7, 2024
1 parent 3d89250 commit 707be68
Show file tree
Hide file tree
Showing 15 changed files with 26 additions and 231 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/azure-static-web-apps-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Azure Static Web Apps web components
on:
push:
branches:
- web-components-v3
- master
paths:
- packages/web-components/**
workflow_dispatch:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/check-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,4 @@ jobs:
core.exportVariable('BEACHBALL_VERSION', beachballVersion);
- run: |
npx beachball@$BEACHBALL_VERSION check -b web-components-v3
node ./scripts/beachball/check-wc-3-changefiles
npx beachball@$BEACHBALL_VERSION check
2 changes: 1 addition & 1 deletion apps/vr-tests-web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dependencies": {
"@fluentui/react-button": "*",
"@fluentui/react-storybook-addon": "*",
"@fluentui/web-components": "3.0.0-beta.15",
"@fluentui/web-components": ">=3.0.0-alpha",
"tslib": "^2.1.0"
}
}
1 change: 0 additions & 1 deletion azure-pipelines-pr.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
pr:
- master
- web-components-v3 # Remove before merging to master

# There's a separate pipeline for CI which also uses this file, but with a trigger override in the UI
# https://dev.azure.com/uifabric/fabricpublic/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=164&view=Tab_Triggers
Expand Down
2 changes: 0 additions & 2 deletions azure-pipelines.bundlesize.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
pr:
- master
- web-components-v3 # Remove before merging to master

trigger:
- master
- web-components-v3 # Remove before merging to master

variables:
- ${{ if not(startsWith(variables['Build.SourceBranch'], 'refs/heads/')) }}:
Expand Down
6 changes: 3 additions & 3 deletions azure-pipelines.release.web-components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ schedules:
displayName: 'Daily release (M-F at 5am UTC+1)'
branches:
include:
- web-components-v3
- master

extends:
template: v1/1ES.Official.PipelineTemplate.yml@1esPipelines
Expand Down Expand Up @@ -75,8 +75,8 @@ extends:
displayName: Build, [test], Lint
- script: |
yarn beachball publish -b origin/web-components-v3 --access public -y -n $(npmToken) --config scripts/beachball/release-web-components.config.js
git reset --hard origin/web-components-v3
yarn publish:beachball -n $(npmToken) --config scripts/beachball/release-web-components.config.js
git reset --hard origin/master
env:
GITHUB_PAT: $(githubPAT)
displayName: Publish changes and bump versions
Expand Down
1 change: 0 additions & 1 deletion azure-pipelines.vrt-pr.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
pr:
- master
- web-components-v3

# There's a separate pipeline for CI which also uses this file, but with a trigger override in the UI.
# https://dev.azure.com/uifabric/fabricpublic/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=164&view=Tab_Triggers
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: merge wc-3 to master - avoiding any library bumps",
"packageName": "@fluentui/web-components",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"builddemo": "yarn build --to public-docsite-resources",
"buildto": "lage build --verbose --to",
"bundle": "lage bundle --verbose",
"change": "beachball change --no-commit -b web-components-v3",
"check:change": "beachball check -b web-components-v3",
"change": "beachball change --no-commit",
"check:change": "beachball check",
"check:modified-files": "node -r ./scripts/ts-node/register ./scripts/executors/check-for-modified-files",
"check:affected": "node ./scripts/executors/checkIfPackagesAffected.js",
"check:installed-dependencies-versions": "satisfied --no-peers --skip-invalid",
Expand Down Expand Up @@ -369,9 +369,7 @@
"typings"
],
"nohoist": [
"@fluentui/web-components/@storybook/html",
"@fluentui/web-components/@microsoft/api-extractor",
"@fluentui/web-components/@microsoft/api-extractor/**"
"@fluentui/web-components/@storybook/html"
]
},
"resolutions": {
Expand Down
4 changes: 1 addition & 3 deletions packages/web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,9 @@
},
"devDependencies": {
"@types/web": "^0.0.142",
"@microsoft/api-extractor": "7.31.2",
"@storybook/html": "6.5.15",
"@tensile-perf/web-components": "~0.1.13",
"rimraf": "^3.0.2",
"typescript": "4.7.4"
"rimraf": "^3.0.2"
},
"dependencies": {
"@microsoft/fast-element": "2.0.0-beta.26",
Expand Down
74 changes: 0 additions & 74 deletions scripts/beachball/check-wc-3-changefiles.js

This file was deleted.

122 changes: 0 additions & 122 deletions scripts/beachball/check-wc-3-changefiles.spec.ts

This file was deleted.

4 changes: 1 addition & 3 deletions scripts/beachball/release-web-components.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
if (process.env.NODE_ENV !== 'test') {
require('../ts-node-register');
}
require('./register').register();

const { config: sharedConfig } = require('./shared.config');
const { getConfig } = require('./utils');
Expand Down
17 changes: 8 additions & 9 deletions scripts/beachball/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ export function getConfig({ version }: { version: 'vNext' }): {
export function getConfig({ version }: { version: 'v8' | 'vNext' | 'web-components' }) {
const vNextPackagePaths = getVNextPackagePaths();

if (version === 'web-components') {
const ignoreVNextScope = vNextPackagePaths.map(path => `!${path}`);
return {
scope: ['packages/web-components', '!apps/*', ...ignoreVNextScope],
};
}

if (version === 'vNext') {
return {
scope: [...vNextPackagePaths],
Expand All @@ -38,9 +31,15 @@ export function getConfig({ version }: { version: 'v8' | 'vNext' | 'web-componen
};
}

if (version === 'v8') {
const ignoreVNextScope = vNextPackagePaths.map(pkgPath => `!${pkgPath}`);
const ignoreVNextScope = vNextPackagePaths.map(path => `!${path}`);

if (version === 'web-components') {
return {
scope: ['packages/web-components', '!apps/*', ...ignoreVNextScope],
};
}

if (version === 'v8') {
return { scope: [...ignoreVNextScope] };
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ type ProjectIssues = { [projectName: string]: { [depName: string]: string } };

const NORMALIZED_INNER_WORKSPACE_VERSION = '*';
const NORMALIZED_PRERELEASE_RANGE_VERSION = '>=9.0.0-alpha';
const NORMALIZED_WEB_COMPONENTS_PRERELEASE_RANGE_VERSION = '>=3.0.0-beta';
const BEACHBALL_UNWANTED_PRERELEASE_RANGE_VERSION_REGEXP = /<9.0.0$/;

export default async function (tree: Tree, schema: NormalizePackageDependenciesGeneratorSchema) {
Expand Down Expand Up @@ -128,9 +127,6 @@ function getVersion(tree: Tree, deps: Record<string, string>, packageName: strin
}

if (semver.prerelease(current)) {
if (semver.satisfies(current, NORMALIZED_WEB_COMPONENTS_PRERELEASE_RANGE_VERSION)) {
return current;
}
return NORMALIZED_PRERELEASE_RANGE_VERSION;
}

Expand Down

0 comments on commit 707be68

Please sign in to comment.