Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Stable script broken once component stories are added #32878

Closed
2 tasks done
Mitch-At-Work opened this issue Sep 20, 2024 · 0 comments · Fixed by #32830
Closed
2 tasks done

[Bug]: Stable script broken once component stories are added #32878

Mitch-At-Work opened this issue Sep 20, 2024 · 0 comments · Fixed by #32830

Comments

@Mitch-At-Work
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Windows 10 10.0.22635
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12800H
    Memory: 11.77 GB / 31.69 GB
  Browsers:
    Edge: Chromium (127.0.2651.8)
    Internet Explorer: 11.0.22621.3566

Are you reporting an Accessibility issue?

no

Reproduction

N/a as build tools - can reproduce by creating a new package and adding a component then stabalizing.

Bug Description

Actual Behavior

running yarn nx g @fluentui/workspace-plugin:prepare-initial-release --project {package-name} --phase=stable succeeds on a freshly generated package via yarn create-package

Once a component is added to the package via yarn create-component - the stories fail to migrate to stable as they have already been renamed to remove preview.

It seems that once the stories are reached, the 'preview' segment has already been removed from the file location, and is not able to find the package name.

Expected Behavior

Stable script should work after adding components and migrate stories correctly.

Logs

yarn nx g @fluentui/workspace-plugin:prepare-initial-release --project react-carousel-preview --phase=stable --verbose
yarn run v1.23.34
$ C:\Users\mifraser\Development\fluentui\node_modules\.bin\nx g @fluentui/workspace-plugin:prepare-initial-release --project react-carousel-preview --phase=stable --verbose

 NX  Generating @fluentui/workspace-plugin:prepare-initial-release

 NX  Falling back to ts-node for local typescript execution. This may be a little slower.
  - To fix this, ensure @swc-node/register and @swc/core have been installed

 NX   Cannot find configuration for 'react-carousel-preview-stories'


Error: Cannot find configuration for 'react-carousel-preview-stories'
    at readProjectConfiguration (C:\Users\mifraser\Development\fluentui\node_modules\nx\src\generators\utils\project-configuration.js:103:15)
    at getProjectConfig (C:\Users\mifraser\Development\fluentui\tools\workspace-plugin\src\utils.ts:132:49)
    at C:\Users\mifraser\Development\fluentui\tools\workspace-plugin\src\generators\prepare-initial-release\index.ts:245:43
    at Array.forEach (<anonymous>)
    at stableRelease (C:\Users\mifraser\Development\fluentui\tools\workspace-plugin\src\generators\prepare-initial-release\index.ts:244:31)
    at async default_1 (C:\Users\mifraser\Development\fluentui\tools\workspace-plugin\src\generators\prepare-initial-release\index.ts:45:16)
    at async C:\Users\mifraser\Development\fluentui\node_modules\nx\src\command-line\generate\generate.js:241:26
    at async handleErrors (C:\Users\mifraser\Development\fluentui\node_modules\nx\src\utils\params.js:22:24)
    at async Object.handler (C:\Users\mifraser\Development\fluentui\node_modules\nx\src\command-line\generate\command-object.js:13:22)

Requested priority

Blocking

Products/sites affected

Stable release timeline (carousel)

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment