Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Release Tool: Ignore -preview in project search and package update #32879

Conversation

Mitch-At-Work
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work commented Sep 20, 2024

NOTE: This will resolve the stable script issues, however it requires further investigation and testing, it could be possible that the script structure can be changed to retain the -preview tag here when appropriate, currently this will not rename all -preview strings within the library files automatically, but it does work on files and namespaces.

Previous Behavior

  • Unknown projects was retrieving project names with the -preview tag attached, however when it cycles to stories, -preview has already been removed from the package name as part of the initial modifications.
  • Incorrect 'storyboook' name error

New Behavior

  • Packages are found in project tree without considering '-preview', this should include packages that match the provided package name, but have already been package parsed and require updating.
  • Fixed incorrect 'storyboook' to 'storybook'

Related Issue(s)

@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner September 20, 2024 17:17
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@Mitch-At-Work Mitch-At-Work marked this pull request as draft September 20, 2024 19:41
@Mitch-At-Work
Copy link
Contributor Author

We can close this as it has been resolved in: #32830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Stable script broken once component stories are added
2 participants