Update office-fabric-ui-core dev dependency #10987
Conversation
maxwellred
requested review from
dzearing,
ecraig12345 and
kenotron
as code owners
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 789fc92ea290a9d88394c3edfc75effd85efafc1 (build) |
Component Perf AnalysisNo significant results to display. All results
|
|
Is there any way this upgrade could possibly cause a breaking change for consumers? (Not in the sense of a code break probably, but some unexpected styling or bundle size impact.) |
|
Hi @ecraig12345 I spoke with Peter and he did say it would probably increase bundle size considering the addition of many new icons. |
|
@maxwellred Any chance you can find numbers of how much it increases the bundle size? Would be nice to communicate that proactively. |
|
@jdhuntington Sorry for the delay. It looks like v11.0.0 is 411.42 kB and v10.0.0 is 369.17 kB so an increase of 42.25 kBs |
|
Hmm. I'm pretty confused by questions and answers here. This increases the fabric core css, which does not impact the bundle size of fabric react or fabric icons. If you include fabric core css in your page, then yes, the css would increase the page size. No bundles are created from the css though. |
|
Hi @dzearing @ecraig12345 @jdhuntington So I there's two mistakes on my part that can clear all this up. 1) I mistook package size for bundle size in my latest comment 2) I misquoted Peter (double checked with him now) and this wont affect bundle size (as you have stated in your comment, David). Sorry everyone! |
|
That makes sense now. One other issue I noticed though is that you should also update the core version in fabric-website, fabric-website-resources, and example-app-base (right now both 10 and 11 are being installed due to those packages still depending on 10). |
|
And related to the issue @KevinTCoughlin mentioned in #10449 (comment), could you please update:
|
|
Oh and in Fabric7Overview.md, you should probably update the part where it mentions version 10. In that context it's probably better to say "10 and later" so something like this:
|
|
Looks like you need change files for the additional packages. |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Pull request checklist
$ yarn changeDescription of changes
Updates the office-ui-fabric-core dev dependency in the packages/office-ui-fabric-react/package.json from version 10 to version 11 adding ~ 350 new icons
Microsoft Reviewers: Open in CodeFlow