Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypicking react-button changes from 7.0 into master #15961

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Cherrypicking react-button changes from 7.0 into master #15961

merged 2 commits into from
Nov 17, 2020

Conversation

dzearing
Copy link
Member

This change was missing in master;
2cc0e34

Subsequently there is no renderButton being exported, which is blocking WAC progress with the pre-release.

@dzearing dzearing requested a review from khmakoto as a code owner November 17, 2020 20:34
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a419897:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 880 889 5000
BaseButtonCompat mount 963 977 5000
Breadcrumb mount 42212 41990 5000
Checkbox mount 1558 1616 5000
CheckboxBase mount 1353 1323 5000
ChoiceGroup mount 4999 4987 5000
ComboBox mount 989 1008 1000
CommandBar mount 10071 10170 1000
ContextualMenu mount 6267 6155 1000
DefaultButtonCompat mount 1198 1183 5000
DetailsRow mount 3752 3741 5000
DetailsRowFast mount 3734 3846 5000
DetailsRowNoStyles mount 3573 3581 5000
Dialog mount 1506 1524 1000
DocumentCardTitle mount 1804 1772 1000
Dropdown mount 3577 3512 5000
FocusTrapZone mount 1864 1866 5000
FocusZone mount 1824 1822 5000
IconButtonCompat mount 1851 1840 5000
Label mount 349 347 5000
Layer mount 1865 1855 5000
Link mount 488 490 5000
MenuButtonCompat mount 1580 1546 5000
MessageBar mount 2008 2093 5000
Nav mount 3419 3412 1000
OverflowSet mount 1062 1084 5000
Panel mount 1474 1504 1000
Persona mount 895 905 1000
Pivot mount 1447 1439 1000
PrimaryButtonCompat mount 1354 1357 5000
Rating mount 7947 7937 5000
SearchBox mount 1397 1426 5000
Shimmer mount 2687 2669 5000
Slider mount 2015 2027 5000
SpinButton mount 5203 5219 5000
Spinner mount 423 421 5000
SplitButtonCompat mount 3344 3290 5000
Stack mount 538 518 5000
StackWithIntrinsicChildren mount 1592 1592 5000
StackWithTextChildren mount 4895 4832 5000
SwatchColorPicker mount 10556 10615 5000
Tabs mount 1478 1439 1000
TagPicker mount 2865 2883 5000
TeachingBubble mount 11762 11816 5000
Text mount 457 447 5000
TextField mount 1473 1458 5000
ThemeProvider mount 1976 1981 5000
ThemeProvider virtual-rerender 656 660 5000
Toggle mount 872 833 5000
button mount 696 700 5000
buttonNative mount 118 121 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.52 0.92:1 2000 965
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 633
🔧 Checkbox.Fluent 0.67 0.37 1.81:1 1000 671
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 852
🔧 Dropdown.Fluent 3.03 0.42 7.21:1 1000 3030
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 744
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 447
🔧 Slider.Fluent 1.59 0.46 3.46:1 1000 1594
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 413
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 590

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 185 169 1.09:1
GridMinimalPerf.default 413 383 1.08:1
ImageMinimalPerf.default 444 412 1.08:1
IconMinimalPerf.default 779 722 1.08:1
DropdownManyItemsPerf.default 841 795 1.06:1
TreeWith60ListItems.default 232 218 1.06:1
Image.Fluent 447 421 1.06:1
AvatarMinimalPerf.default 528 502 1.05:1
ButtonMinimalPerf.default 206 196 1.05:1
DividerMinimalPerf.default 431 411 1.05:1
FlexMinimalPerf.default 351 333 1.05:1
LayoutMinimalPerf.default 467 445 1.05:1
ListNestedPerf.default 639 609 1.05:1
LoaderMinimalPerf.default 782 747 1.05:1
SkeletonMinimalPerf.default 507 484 1.05:1
TableMinimalPerf.default 474 450 1.05:1
TextAreaMinimalPerf.default 564 538 1.05:1
ChatDuplicateMessagesPerf.default 444 425 1.04:1
EmbedMinimalPerf.default 2129 2053 1.04:1
ListMinimalPerf.default 544 523 1.04:1
MenuMinimalPerf.default 948 915 1.04:1
TextMinimalPerf.default 411 396 1.04:1
ToolbarMinimalPerf.default 1071 1034 1.04:1
BoxMinimalPerf.default 421 407 1.03:1
ButtonSlotsPerf.default 646 629 1.03:1
ButtonUseCssPerf.default 891 862 1.03:1
ChatMinimalPerf.default 689 669 1.03:1
LabelMinimalPerf.default 478 466 1.03:1
PopupMinimalPerf.default 725 707 1.03:1
RadioGroupMinimalPerf.default 498 484 1.03:1
RefMinimalPerf.default 245 238 1.03:1
SegmentMinimalPerf.default 404 394 1.03:1
VideoMinimalPerf.default 723 703 1.03:1
Avatar.Fluent 965 936 1.03:1
Text.Fluent 413 400 1.03:1
AnimationMinimalPerf.default 446 437 1.02:1
CardMinimalPerf.default 637 626 1.02:1
PortalMinimalPerf.default 167 163 1.02:1
Dialog.Fluent 852 833 1.02:1
Dropdown.Fluent 3030 2957 1.02:1
Tooltip.Fluent 590 581 1.02:1
ButtonOverridesMissPerf.default 1781 1759 1.01:1
DatepickerMinimalPerf.default 48691 48063 1.01:1
DialogMinimalPerf.default 848 840 1.01:1
DropdownMinimalPerf.default 2979 2947 1.01:1
ProviderMinimalPerf.default 1016 1005 1.01:1
SplitButtonMinimalPerf.default 3982 3945 1.01:1
TableManyItemsPerf.default 2451 2422 1.01:1
CustomToolbarPrototype.default 3914 3860 1.01:1
Button.Fluent 633 627 1.01:1
Checkbox.Fluent 671 666 1.01:1
Slider.Fluent 1594 1571 1.01:1
FormMinimalPerf.default 485 486 1:1
HeaderMinimalPerf.default 418 418 1:1
HeaderSlotsPerf.default 878 880 1:1
InputMinimalPerf.default 1363 1359 1:1
ListWith60ListItems.default 978 979 1:1
MenuButtonMinimalPerf.default 1692 1687 1:1
TreeMinimalPerf.default 976 980 1:1
ButtonUseCssNestingPerf.default 1136 1148 0.99:1
CarouselMinimalPerf.default 498 503 0.99:1
CheckboxMinimalPerf.default 2979 2995 0.99:1
ItemLayoutMinimalPerf.default 1403 1420 0.99:1
ListCommonPerf.default 716 720 0.99:1
ProviderMergeThemesPerf.default 2040 2059 0.99:1
TooltipMinimalPerf.default 861 872 0.99:1
AttachmentSlotsPerf.default 1205 1229 0.98:1
ChatWithPopoverPerf.default 493 505 0.98:1
SliderMinimalPerf.default 1563 1596 0.98:1
Icon.Fluent 744 763 0.98:1
AlertMinimalPerf.default 332 344 0.97:1
StatusMinimalPerf.default 803 824 0.97:1
ReactionMinimalPerf.default 447 464 0.96:1
AccordionMinimalPerf.default 168 179 0.94:1

@msft-github-bot
Copy link
Contributor

Hello @dzearing!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@size-auditor
Copy link

size-auditor bot commented Nov 17, 2020

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Button 47.709 kB 48.548 kB ExceedsBaseline     839 bytes
office-ui-fabric-react fluentui-react-ToggleButton 52.612 kB 52.624 kB ExceedsBaseline     12 bytes
office-ui-fabric-react fluentui-react-MenuButton 55.06 kB 55.069 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-CompoundButton 51.433 kB 51.366 kB BelowBaseline     -67 bytes
office-ui-fabric-react fluentui-react-SplitButton 59.114 kB 59.036 kB BelowBaseline     -78 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: e0e80df13c6a6e6ec89268452b1e982ba9a1d644 (build)

@dzearing dzearing merged commit 16bb581 into microsoft:master Nov 17, 2020
@dzearing dzearing deleted the fix/cherrypick-button-change branch November 17, 2020 21:54
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-compose@v1.0.0-beta.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-avatar@v0.8.2-7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-button@v1.0.0-beta.12 has been released which incorporates this pull request.:tada:

Handy links:

SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 23, 2020
@dzearing
Cherrypicking react-button changes from 7.0 into master (microsoft#15961
009e066 
)

* Merging with latest.

* updating change file versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

Assignees

@behowell behowell

Labels
AutoMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzearing @msft-github-bot @khmakoto @behowell