Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set high contrast color on label and status-message in switch component #16106

Merged

Conversation

khamudom
Copy link
Contributor

@khamudom khamudom commented Dec 1, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Set FieldText color on label and status-message to assure the colors are set correctly when the component is being implemented.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92500e8:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Dec 1, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 874 875 5000
BaseButtonCompat mount 955 956 5000
Breadcrumb mount 42391 42456 5000
Checkbox mount 1552 1593 5000
CheckboxBase mount 1339 1334 5000
ChoiceGroup mount 5028 5067 5000
ComboBox mount 995 1000 1000
CommandBar mount 10186 10278 1000
ContextualMenu mount 6242 6191 1000
DefaultButtonCompat mount 1184 1187 5000
DetailsRow mount 3827 3861 5000
DetailsRowFast mount 3872 3909 5000
DetailsRowNoStyles mount 3625 3682 5000
Dialog mount 1517 1511 1000
DocumentCardTitle mount 1880 1808 1000
Dropdown mount 3470 3484 5000
FocusTrapZone mount 1852 1816 5000
FocusZone mount 1865 1875 5000
IconButtonCompat mount 1877 1844 5000
Label mount 350 349 5000
Layer mount 1911 1873 5000
Link mount 467 487 5000
MenuButtonCompat mount 1572 1544 5000
MessageBar mount 2052 2051 5000
Nav mount 3379 3375 1000
OverflowSet mount 1060 1059 5000
Panel mount 1500 1481 1000
Persona mount 884 899 1000
Pivot mount 1426 1462 1000
PrimaryButtonCompat mount 1335 1363 5000
Rating mount 8029 8102 5000
SearchBox mount 1392 1376 5000
Shimmer mount 2714 2757 5000
Slider mount 2031 1993 5000
SpinButton mount 5148 5153 5000
Spinner mount 428 433 5000
SplitButtonCompat mount 3237 3303 5000
Stack mount 524 539 5000
StackWithIntrinsicChildren mount 1586 1569 5000
StackWithTextChildren mount 4816 4780 5000
SwatchColorPicker mount 10605 10597 5000
Tabs mount 1461 1485 1000
TagPicker mount 2888 2960 5000
TeachingBubble mount 11900 11911 5000
Text mount 441 440 5000
TextField mount 1459 1422 5000
ThemeProvider mount 2158 2173 5000
ThemeProvider virtual-rerender 644 648 5000
Toggle mount 818 840 5000
button mount 718 719 5000
buttonNative mount 112 115 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.49 0.54 0.91:1 2000 985
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 671
🔧 Checkbox.Fluent 0.68 0.37 1.84:1 1000 682
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 865
🔧 Dropdown.Fluent 3.07 0.43 7.14:1 1000 3073
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 815
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 424
🔧 Slider.Fluent 1.63 0.46 3.54:1 1000 1631
🔧 Text.Fluent 0.09 0.03 3:1 5000 428
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 588

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 229 206 1.11:1
AccordionMinimalPerf.default 194 177 1.1:1
MenuMinimalPerf.default 1026 955 1.07:1
PortalMinimalPerf.default 185 173 1.07:1
DatepickerMinimalPerf.default 52911 49803 1.06:1
SkeletonMinimalPerf.default 495 467 1.06:1
TextMinimalPerf.default 430 406 1.06:1
Text.Fluent 428 404 1.06:1
AttachmentMinimalPerf.default 204 194 1.05:1
AttachmentSlotsPerf.default 1337 1276 1.05:1
ListWith60ListItems.default 1050 1002 1.05:1
TableMinimalPerf.default 493 468 1.05:1
AvatarMinimalPerf.default 548 529 1.04:1
ButtonUseCssPerf.default 969 928 1.04:1
DividerMinimalPerf.default 436 419 1.04:1
ListCommonPerf.default 774 743 1.04:1
SegmentMinimalPerf.default 430 413 1.04:1
TextAreaMinimalPerf.default 596 575 1.04:1
Button.Fluent 671 647 1.04:1
Icon.Fluent 815 783 1.04:1
BoxMinimalPerf.default 447 435 1.03:1
CardMinimalPerf.default 673 656 1.03:1
FlexMinimalPerf.default 345 334 1.03:1
GridMinimalPerf.default 407 394 1.03:1
ProviderMinimalPerf.default 1107 1079 1.03:1
ReactionMinimalPerf.default 485 470 1.03:1
AnimationMinimalPerf.default 478 468 1.02:1
ButtonUseCssNestingPerf.default 1241 1213 1.02:1
CarouselMinimalPerf.default 518 507 1.02:1
DialogMinimalPerf.default 884 868 1.02:1
InputMinimalPerf.default 1412 1391 1.02:1
ItemLayoutMinimalPerf.default 1456 1429 1.02:1
LabelMinimalPerf.default 485 474 1.02:1
ListMinimalPerf.default 574 562 1.02:1
PopupMinimalPerf.default 772 758 1.02:1
RefMinimalPerf.default 261 255 1.02:1
SliderMinimalPerf.default 1670 1639 1.02:1
StatusMinimalPerf.default 830 816 1.02:1
TooltipMinimalPerf.default 894 877 1.02:1
Avatar.Fluent 985 969 1.02:1
Dialog.Fluent 865 848 1.02:1
Slider.Fluent 1631 1594 1.02:1
ButtonSlotsPerf.default 693 684 1.01:1
ChatDuplicateMessagesPerf.default 470 466 1.01:1
HeaderMinimalPerf.default 444 439 1.01:1
HeaderSlotsPerf.default 911 901 1.01:1
LoaderMinimalPerf.default 802 793 1.01:1
MenuButtonMinimalPerf.default 1744 1735 1.01:1
ProviderMergeThemesPerf.default 2135 2119 1.01:1
SplitButtonMinimalPerf.default 4119 4083 1.01:1
IconMinimalPerf.default 785 780 1.01:1
TableManyItemsPerf.default 2481 2464 1.01:1
TreeMinimalPerf.default 875 865 1.01:1
Tooltip.Fluent 588 584 1.01:1
ButtonOverridesMissPerf.default 1863 1866 1:1
ChatMinimalPerf.default 726 724 1:1
ChatWithPopoverPerf.default 532 534 1:1
CheckboxMinimalPerf.default 3164 3164 1:1
DropdownManyItemsPerf.default 851 851 1:1
DropdownMinimalPerf.default 3142 3130 1:1
EmbedMinimalPerf.default 4437 4445 1:1
FormMinimalPerf.default 487 489 1:1
ImageMinimalPerf.default 463 463 1:1
LayoutMinimalPerf.default 467 467 1:1
RadioGroupMinimalPerf.default 499 497 1:1
VideoMinimalPerf.default 719 717 1:1
ListNestedPerf.default 644 649 0.99:1
CustomToolbarPrototype.default 4069 4103 0.99:1
Checkbox.Fluent 682 691 0.99:1
Dropdown.Fluent 3073 3098 0.99:1
AlertMinimalPerf.default 358 366 0.98:1
ToolbarMinimalPerf.default 1053 1079 0.98:1
TreeWith60ListItems.default 221 227 0.97:1
Image.Fluent 424 439 0.97:1

@size-auditor
Copy link

size-auditor bot commented Dec 1, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f4a9623307b170961870d5a5743cf1f7fb2f005a (build)

@khamudom khamudom force-pushed the users/khamu/switch-label-indicator-hc branch from a1dc16b to a882b87 Compare December 2, 2020 17:44
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khamudom!

@chrisdholt chrisdholt merged commit 2bba2c2 into microsoft:master Dec 8, 2020
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v0.9.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants