fix(libuv): fix sporadic libuv assertion fails
#16513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1cd881a:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
kubkon
force-pushed
the
bump-webpack-webcomponents
branch
from
a2ab7b9
to
96708e5
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9ffa0f0a5eaacfa5414dbcdaae75d7753087a0b6 (build) |
chrisdholt
requested changes
Jan 18, 2021
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "type": "patch", | |||
There was a problem hiding this comment.
As this does not change distributed files, the package version shouldn’t update. Can you make this “none”?
The fix turns out to be bumping `webpack` from `4.43` to `4.44` in `packages/web-components`. Prior to this, I'd experience sporadic errors when running `yarn test` like the ones documented in this `karma` issue: [karma-runner/karma#3511](karma-runner/karma#3511). It turns out, that the problem is not with `karma` but rather with `webpack` as documented in [webpack/webpack#10037](webpack/webpack#10037). As per the closing comment in that issue, ensure we use `watchpack` version `^1.7.2` (a transitive dep of `webpack`) is enough to ensure this sporadic error goes away, and to bump `watchpack` we need to bump `webpack` by one minor version.
kubkon
force-pushed
the
bump-webpack-webcomponents
branch
from
96708e5
to
1cd881a
Compare
|
@kubkon trying to get my PR in ASAP; just lots of little stupid things breaking. Fix thing, build locally, celebrate success, check in, wait on build, get surprised by something breaking, depression, investigate, repeat... makes it hard to estimate, but this is my main priority at the moment. |
|
This is now superseded by #16447, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The fix turns out to be bumping
webpackfrom4.43to4.44inpackages/web-components. Prior to this, I'd experience sporadicerrors when running
yarn testlike the ones documented in thiskarmaissue: karma-runner/karma#3511.It turns out, that the problem is not with
karmabut rather withwebpackas documented in webpack/webpack#10037.As per the closing comment in that issue, ensure we use
watchpackversion
^1.7.2(a transitive dep ofwebpack) is enough to ensurethis sporadic error goes away, and to bump
watchpackwe need tobump
webpackby one minor version.