Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping formik and react typings #16548

Merged
merged 12 commits into from
Jan 21, 2021
Merged

Bumping formik and react typings #16548

merged 12 commits into from
Jan 21, 2021

Conversation

dzearing
Copy link
Member

In order to move to webpack 5, we need to bump formik as the older version depends on non-exported things from scheduler. In order to bump formik, we need to update react typings, as the new one is incompatible with the old typings.

We can't update to the latest react 16 typings because that will pull in the latest csstype (v3), which will introduce multiple copies of that, as other dependencies still require v2. This in turn creates more typescript errors.

Found a version of react typings which doesn't update csstype, but is compatible with formik Local build is happy. Crossing fingers everything works in CI.

@DustyTheBot
Copy link

DustyTheBot commented Jan 20, 2021 •
edited
Loading

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against b702409

chrisdholt
chrisdholt requested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request here from a web-components dependency standpoint. If we add that peer dependency, then I think this can be considered a "patch". If we don't add that, I don't think this would rev the packages and the change would be "none".

packages/web-components/package.json Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 20, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b702409:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 20, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 898 950 5000
BaseButtonCompat mount 1002 993 5000
Breadcrumb mount 46586 47143 5000
Checkbox mount 1735 1714 5000
CheckboxBase mount 1426 1468 5000
ChoiceGroup mount 5286 5350 5000
ComboBox mount 1046 1049 1000
CommandBar mount 10885 10899 1000
ContextualMenu mount 6527 6614 1000
DefaultButtonCompat mount 1254 1261 5000
DetailsRow mount 3981 4061 5000
DetailsRowFast mount 3978 4019 5000
DetailsRowNoStyles mount 3805 3725 5000
Dialog mount 1566 1582 1000
DocumentCardTitle mount 1902 1913 1000
Dropdown mount 3548 3559 5000
FocusTrapZone mount 1905 1877 5000
FocusZone mount 1895 1942 5000
IconButtonCompat mount 1876 1948 5000
Label mount 354 374 5000
Layer mount 1935 1909 5000
Link mount 500 491 5000
MakeStyles mount 2064 2114 50000
MenuButtonCompat mount 1600 1622 5000
MessageBar mount 2066 2093 5000
Nav mount 3472 3463 1000
OverflowSet mount 1097 1092 5000
Panel mount 1506 1432 1000
Persona mount 914 917 1000
Pivot mount 1499 1469 1000
PrimaryButtonCompat mount 1371 1401 5000
Rating mount 8298 8274 5000
SearchBox mount 1429 1436 5000
Shimmer mount 2781 2772 5000
Slider mount 1994 1997 5000
SpinButton mount 5332 5525 5000
Spinner mount 449 438 5000
SplitButtonCompat mount 3410 3399 5000
Stack mount 532 548 5000
StackWithIntrinsicChildren mount 1621 1646 5000
StackWithTextChildren mount 4936 4905 5000
SwatchColorPicker mount 10872 10880 5000
Tabs mount 1459 1503 1000
TagPicker mount 3048 3025 5000
TeachingBubble mount 12099 12074 5000
Text mount 452 441 5000
TextField mount 1506 1527 5000
ThemeProvider mount 2314 2289 5000
ThemeProvider virtual-rerender 692 685 5000
Toggle mount 871 869 5000
button mount 786 748 5000
buttonNative mount 120 121 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.57 0.33:1 2000 388
🦄 Button.Fluent 0.14 0.22 0.64:1 5000 677
🔧 Checkbox.Fluent 0.71 0.39 1.82:1 1000 705
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 892
🔧 Dropdown.Fluent 3.18 0.45 7.07:1 1000 3177
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 791
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 464
🔧 Slider.Fluent 1.67 0.47 3.55:1 1000 1673
🔧 Text.Fluent 0.09 0.03 3:1 5000 429
🦄 Tooltip.Fluent 0.12 0.94 0.13:1 5000 619

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 226 206 1.1:1
ListCommonPerf.default 780 714 1.09:1
ChatDuplicateMessagesPerf.default 437 406 1.08:1
DatepickerMinimalPerf.default 55150 51249 1.08:1
RefMinimalPerf.default 262 243 1.08:1
CarouselMinimalPerf.default 584 547 1.07:1
Icon.Fluent 791 744 1.06:1
AvatarMinimalPerf.default 240 229 1.05:1
DividerMinimalPerf.default 455 433 1.05:1
SegmentMinimalPerf.default 444 423 1.05:1
VideoMinimalPerf.default 761 723 1.05:1
Text.Fluent 429 410 1.05:1
FlexMinimalPerf.default 348 335 1.04:1
PopupMinimalPerf.default 783 755 1.04:1
Button.Fluent 677 654 1.04:1
ChatWithPopoverPerf.default 538 520 1.03:1
EmbedMinimalPerf.default 4542 4409 1.03:1
ListNestedPerf.default 668 649 1.03:1
MenuButtonMinimalPerf.default 1806 1759 1.03:1
ReactionMinimalPerf.default 479 467 1.03:1
SkeletonMinimalPerf.default 440 428 1.03:1
TableMinimalPerf.default 483 470 1.03:1
AlertMinimalPerf.default 366 359 1.02:1
CardMinimalPerf.default 679 665 1.02:1
CheckboxMinimalPerf.default 3237 3170 1.02:1
FormMinimalPerf.default 495 483 1.02:1
HeaderMinimalPerf.default 435 425 1.02:1
ItemLayoutMinimalPerf.default 1430 1396 1.02:1
LabelMinimalPerf.default 500 489 1.02:1
LayoutMinimalPerf.default 482 471 1.02:1
LoaderMinimalPerf.default 804 789 1.02:1
MenuMinimalPerf.default 994 970 1.02:1
ProviderMergeThemesPerf.default 1658 1628 1.02:1
RadioGroupMinimalPerf.default 522 510 1.02:1
TextMinimalPerf.default 430 423 1.02:1
ToolbarMinimalPerf.default 1077 1059 1.02:1
Dropdown.Fluent 3177 3111 1.02:1
AnimationMinimalPerf.default 491 488 1.01:1
AttachmentSlotsPerf.default 1422 1410 1.01:1
ChatMinimalPerf.default 719 713 1.01:1
HeaderSlotsPerf.default 900 895 1.01:1
ListMinimalPerf.default 572 569 1.01:1
PortalMinimalPerf.default 170 169 1.01:1
SliderMinimalPerf.default 1652 1640 1.01:1
SplitButtonMinimalPerf.default 4107 4086 1.01:1
TextAreaMinimalPerf.default 587 584 1.01:1
CustomToolbarPrototype.default 3915 3890 1.01:1
TooltipMinimalPerf.default 916 911 1.01:1
TreeMinimalPerf.default 897 885 1.01:1
Avatar.Fluent 388 384 1.01:1
Dialog.Fluent 892 885 1.01:1
Slider.Fluent 1673 1664 1.01:1
AttachmentMinimalPerf.default 205 205 1:1
BoxMinimalPerf.default 433 432 1:1
ButtonOverridesMissPerf.default 1892 1896 1:1
ButtonSlotsPerf.default 673 672 1:1
ButtonUseCssNestingPerf.default 1240 1234 1:1
DialogMinimalPerf.default 869 870 1:1
DropdownManyItemsPerf.default 830 830 1:1
DropdownMinimalPerf.default 3090 3086 1:1
ImageMinimalPerf.default 475 477 1:1
TableManyItemsPerf.default 2346 2348 1:1
Image.Fluent 464 464 1:1
InputMinimalPerf.default 1366 1379 0.99:1
ListWith60ListItems.default 724 733 0.99:1
StatusMinimalPerf.default 832 837 0.99:1
IconMinimalPerf.default 744 753 0.99:1
TreeWith60ListItems.default 194 196 0.99:1
Checkbox.Fluent 705 711 0.99:1
Tooltip.Fluent 619 624 0.99:1
AccordionMinimalPerf.default 196 200 0.98:1
GridMinimalPerf.default 391 397 0.98:1
ProviderMinimalPerf.default 989 1013 0.98:1
ButtonUseCssPerf.default 947 997 0.95:1
RosterPerf.default 1320 1396 0.95:1

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-window-provider@v2.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-slider@v1.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-toggle@v1.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.0.0-beta.39 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-stylesheets@v1.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-text@v0.1.3-14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-shared-contexts@v1.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabs@v1.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme-provider@v1.0.0-beta.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-monaco-editor@v1.0.0-beta.38 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-link@v1.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-hooks@v8.0.0-beta.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-focus@v8.0.0-beta.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-image@v0.6.19-14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icons-mdl2@v1.0.0-beta.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.0.0-beta.39 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.0.0-beta.42 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-flex@v0.2.2-14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-file-type-icons@v8.0.0-beta.14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v1.0.0-beta.38 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-avatar@v0.8.2-15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-checkbox@v1.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-compose@v1.0.0-beta.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-date-time@v8.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v1.0.0-beta.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/foundation-legacy@v8.0.0-beta.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-merge-styles@v8.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/codemods@v1.0.0-beta.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-charting@v5.0.0-beta.39 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-internal@v8.0.0-beta.35 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@assuncaocharles assuncaocharles Awaiting requested review from assuncaocharles

@behowell behowell Awaiting requested review from behowell

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers bigbadcapers is a code owner

@evlevy evlevy Awaiting requested review from evlevy

@Jahnp Jahnp Awaiting requested review from Jahnp Jahnp is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore

@joschect joschect Awaiting requested review from joschect

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

@kolaps33 kolaps33 Awaiting requested review from kolaps33

@layershifter layershifter Awaiting requested review from layershifter

@ling1726 ling1726 Awaiting requested review from ling1726

@lorejoh12 lorejoh12 Awaiting requested review from lorejoh12

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

@Raghurk Raghurk Awaiting requested review from Raghurk

@xugao xugao Awaiting requested review from xugao

@aditima aditima Awaiting requested review from aditima

@yiminwu yiminwu Awaiting requested review from yiminwu

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@Vitalius1 Vitalius1 Awaiting requested review from Vitalius1

Assignees

@layershifter layershifter

Labels
PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dzearing @DustyTheBot @fabricteam @msft-fluent-ui-bot @ecraig12345 @chrisdholt @layershifter