Adds a Module Federation innerloop experience #16771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenotron
requested review from
dzearing,
ecraig12345 and
xugao
as code owners
dzearing
approved these changes
Feb 2, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8ea8f2e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 677134343636ac373093f59cc67f5c09ab3bc21f (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
reviewed
Feb 2, 2021
| @@ -25,7 +25,8 @@ | |||
| "start:legacy": "yarn workspace @fluentui/public-docsite-resources start", | |||
| "start-test": "just-scripts jest-watch", | |||
| "test": "just-scripts test", | |||
| "update-snapshots": "just-scripts jest -u" | |||
| "update-snapshots": "just-scripts jest -u", | |||
| "mf": "just-scripts mf" | |||
There was a problem hiding this comment.
Can we...maybe find a different acronym? 🤣
There was a problem hiding this comment.
hahahah mf is everywhere :)
ecraig12345
reviewed
Feb 2, 2021
| const { createServeConfig } = require('@fluentui/scripts/webpack/webpack-resources'); | ||
| const { webpackMerge } = require('just-scripts'); | ||
|
|
||
| const shared = { |
There was a problem hiding this comment.
I know I say this all the time but it would probably help to have some comments in here in case anyone else needs to maintain it later.
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Addresses an existing issue: Fixes #0000$ yarn changeDescription of changes
This adds a
just-scriptstask called "mf" that can be triggered through the commandyarn mfin thepackages/reactfolder. When this is run, awebpack-dev-servertask is triggered, generating a module federation bundle, served through the WDS. This can then be fed into any MF consumer through the global var offluentuiReact. This global var mechanism can be changed, but needs some investigation. So far, this has proven to be a good innerloop experience in coordination of the @lading/server "manifest service"Focus areas to test
(optional)