fix(MenuItem): prevent to dismiss menu on scroll inside menu #17294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assuncaocharles
requested review from
jurokapsiar,
layershifter,
ling1726,
miroslavstastny and
pompomon
as code owners
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
layershifter
reviewed
Mar 5, 2021
packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Mar 5, 2021
….tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d75d24f:
|
ling1726
approved these changes
Mar 5, 2021
Asset size changes
Baseline commit: d9fb5e3ce8dfdf0f6fdb5dee945a29243ec85dc9 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
YuanboXue-Amber
pushed a commit
that referenced
this pull request
Mar 9, 2021
* fix(MenuItem): prevent to dimiss menu on scroll inside menu * fix(MenuItem): add changelog * Update packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
2 tasks
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…ft#17294) * fix(MenuItem): prevent to dimiss menu on scroll inside menu * fix(MenuItem): add changelog * Update packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…ft#17294) * fix(MenuItem): prevent to dimiss menu on scroll inside menu * fix(MenuItem): add changelog * Update packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Prevent submenu to be dismissed when scroll happens inside
MenuFocus areas to test
(optional)