-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Screener test for Chat for V2 themes #18946
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2bd66a:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5bf5b8e682004069501664192082c22a7a6f51ac (build) |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 781 | 804 | 5000 | |
BaseButton | mount | 879 | 877 | 5000 | |
Breadcrumb | mount | 2649 | 2694 | 1000 | |
ButtonNext | mount | 519 | 523 | 5000 | |
Checkbox | mount | 1483 | 1495 | 5000 | |
CheckboxBase | mount | 1336 | 1279 | 5000 | |
ChoiceGroup | mount | 4670 | 4714 | 5000 | |
ComboBox | mount | 998 | 952 | 1000 | |
CommandBar | mount | 10027 | 10061 | 1000 | |
ContextualMenu | mount | 6227 | 6190 | 1000 | |
DefaultButton | mount | 1108 | 1115 | 5000 | |
DetailsRow | mount | 3666 | 3668 | 5000 | |
DetailsRowFast | mount | 3743 | 3702 | 5000 | |
DetailsRowNoStyles | mount | 3502 | 3506 | 5000 | |
Dialog | mount | 2136 | 2124 | 1000 | |
DocumentCardTitle | mount | 137 | 140 | 1000 | |
Dropdown | mount | 3187 | 3194 | 5000 | |
FluentProviderNext | mount | 7244 | 7220 | 5000 | |
FocusTrapZone | mount | 1752 | 1781 | 5000 | |
FocusZone | mount | 1783 | 1802 | 5000 | |
IconButton | mount | 1697 | 1706 | 5000 | |
Label | mount | 342 | 346 | 5000 | |
Layer | mount | 1743 | 1776 | 5000 | |
Link | mount | 453 | 464 | 5000 | |
MakeStyles | mount | 1780 | 1814 | 50000 | |
MenuButton | mount | 1425 | 1420 | 5000 | |
MessageBar | mount | 1968 | 2005 | 5000 | |
Nav | mount | 3196 | 3233 | 1000 | |
OverflowSet | mount | 1032 | 1032 | 5000 | |
Panel | mount | 1363 | 1354 | 1000 | |
Persona | mount | 801 | 814 | 1000 | |
Pivot | mount | 1370 | 1409 | 1000 | |
PrimaryButton | mount | 1281 | 1290 | 5000 | |
Rating | mount | 7525 | 7617 | 5000 | |
SearchBox | mount | 1297 | 1263 | 5000 | |
Shimmer | mount | 2485 | 2560 | 5000 | |
Slider | mount | 1939 | 1922 | 5000 | |
SpinButton | mount | 4893 | 4864 | 5000 | |
Spinner | mount | 430 | 420 | 5000 | |
SplitButton | mount | 3110 | 3141 | 5000 | |
Stack | mount | 494 | 497 | 5000 | |
StackWithIntrinsicChildren | mount | 1480 | 1493 | 5000 | |
StackWithTextChildren | mount | 4332 | 4408 | 5000 | |
SwatchColorPicker | mount | 10044 | 10118 | 5000 | |
Tabs | mount | 1365 | 1379 | 1000 | |
TagPicker | mount | 2397 | 2368 | 5000 | |
TeachingBubble | mount | 11676 | 11812 | 5000 | |
Text | mount | 405 | 403 | 5000 | |
TextField | mount | 1349 | 1373 | 5000 | |
ThemeProvider | mount | 1183 | 1168 | 5000 | |
ThemeProvider | virtual-rerender | 590 | 597 | 5000 | |
Toggle | mount | 791 | 783 | 5000 | |
buttonNative | mount | 114 | 117 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AccordionMinimalPerf.default | 170 | 146 | 1.16:1 |
AttachmentMinimalPerf.default | 168 | 148 | 1.14:1 |
ButtonSlotsPerf.default | 550 | 525 | 1.05:1 |
ListCommonPerf.default | 629 | 599 | 1.05:1 |
ReactionMinimalPerf.default | 379 | 361 | 1.05:1 |
TableMinimalPerf.default | 407 | 389 | 1.05:1 |
TreeWith60ListItems.default | 181 | 172 | 1.05:1 |
DropdownManyItemsPerf.default | 685 | 656 | 1.04:1 |
SegmentMinimalPerf.default | 355 | 341 | 1.04:1 |
ButtonMinimalPerf.default | 161 | 157 | 1.03:1 |
CardMinimalPerf.default | 554 | 540 | 1.03:1 |
DialogMinimalPerf.default | 761 | 738 | 1.03:1 |
FormMinimalPerf.default | 396 | 385 | 1.03:1 |
RefMinimalPerf.default | 231 | 224 | 1.03:1 |
TextMinimalPerf.default | 342 | 333 | 1.03:1 |
ChatWithPopoverPerf.default | 366 | 359 | 1.02:1 |
DatepickerMinimalPerf.default | 5618 | 5492 | 1.02:1 |
DividerMinimalPerf.default | 363 | 357 | 1.02:1 |
PortalMinimalPerf.default | 175 | 171 | 1.02:1 |
IconMinimalPerf.default | 605 | 591 | 1.02:1 |
ChatMinimalPerf.default | 638 | 631 | 1.01:1 |
GridMinimalPerf.default | 328 | 326 | 1.01:1 |
ListNestedPerf.default | 551 | 547 | 1.01:1 |
ListWith60ListItems.default | 626 | 622 | 1.01:1 |
MenuButtonMinimalPerf.default | 1621 | 1604 | 1.01:1 |
PopupMinimalPerf.default | 582 | 579 | 1.01:1 |
SkeletonMinimalPerf.default | 352 | 347 | 1.01:1 |
SplitButtonMinimalPerf.default | 3744 | 3702 | 1.01:1 |
AnimationMinimalPerf.default | 416 | 417 | 1:1 |
AttachmentSlotsPerf.default | 1056 | 1054 | 1:1 |
BoxMinimalPerf.default | 345 | 344 | 1:1 |
InputMinimalPerf.default | 1246 | 1241 | 1:1 |
LabelMinimalPerf.default | 376 | 375 | 1:1 |
LayoutMinimalPerf.default | 359 | 360 | 1:1 |
LoaderMinimalPerf.default | 684 | 681 | 1:1 |
ProviderMergeThemesPerf.default | 1644 | 1652 | 1:1 |
ProviderMinimalPerf.default | 961 | 963 | 1:1 |
TableManyItemsPerf.default | 1872 | 1864 | 1:1 |
ToolbarMinimalPerf.default | 902 | 904 | 1:1 |
TooltipMinimalPerf.default | 992 | 995 | 1:1 |
AvatarMinimalPerf.default | 189 | 190 | 0.99:1 |
DropdownMinimalPerf.default | 3073 | 3111 | 0.99:1 |
EmbedMinimalPerf.default | 4018 | 4046 | 0.99:1 |
HeaderMinimalPerf.default | 347 | 351 | 0.99:1 |
HeaderSlotsPerf.default | 730 | 737 | 0.99:1 |
ListMinimalPerf.default | 500 | 505 | 0.99:1 |
CustomToolbarPrototype.default | 3710 | 3746 | 0.99:1 |
TreeMinimalPerf.default | 782 | 789 | 0.99:1 |
CarouselMinimalPerf.default | 445 | 454 | 0.98:1 |
ChatDuplicateMessagesPerf.default | 284 | 289 | 0.98:1 |
CheckboxMinimalPerf.default | 2662 | 2715 | 0.98:1 |
ItemLayoutMinimalPerf.default | 1180 | 1198 | 0.98:1 |
MenuMinimalPerf.default | 825 | 846 | 0.98:1 |
RosterPerf.default | 1131 | 1156 | 0.98:1 |
RadioGroupMinimalPerf.default | 419 | 429 | 0.98:1 |
SliderMinimalPerf.default | 1518 | 1552 | 0.98:1 |
StatusMinimalPerf.default | 656 | 669 | 0.98:1 |
TextAreaMinimalPerf.default | 479 | 489 | 0.98:1 |
ButtonOverridesMissPerf.default | 1656 | 1701 | 0.97:1 |
ImageMinimalPerf.default | 351 | 362 | 0.97:1 |
VideoMinimalPerf.default | 608 | 624 | 0.97:1 |
FlexMinimalPerf.default | 277 | 288 | 0.96:1 |
AlertMinimalPerf.default | 261 | 287 | 0.91:1 |
Please add a changelog |
I didn't add one before as there are no visible changes to any users, not even for documentation. If you'd still like me to add one, what section would this kind of change fall under?
|
ah yeah, brain fart on my end, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add Screener test for Chat for V2 themes * Fix message selector
The V2 themes add a few new overrides for the Chat Components.
To prevent them regressing for those themes, this PR adds screener tests with the v2 themes.
Also adds a hover-step for compact chat to test interaction.