-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix d.ts errors generated by api-extractor #21945
fix d.ts errors generated by api-extractor #21945
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99ab560:
|
📊 Bundle size report🤖 This report was generated against 1f83caa61c5bea877ec67667ef748aaaf50ad14b |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1f83caa61c5bea877ec67667ef748aaaf50ad14b (build) |
5cfe62f
to
99ab560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radium-v do you want to open this beyond draft? Looks good to all of us :)
Current Behavior
The
web-components.d.ts
file generated by API Extractor contains errors, and I'm not really sure what caused them to appear:New Behavior
I cast the object passed to the
compose()
function for bothTextArea
andTextField
as aFoundationElementDefinition
, which is what it should default to. This is the most succinct solution I could find for these specific errors.