Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stable version of fast foundation to provide bug fixes #27506

Merged
merged 3 commits into from
Apr 10, 2023
Merged

update stable version of fast foundation to provide bug fixes #27506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cabea43
update stable version of fast foundation to provide bug fixes
chrisdholt Apr 10, 2023
41228ea
Merge branch 'master' into users/chhol/update-fast-stable-package-ver…
chrisdholt Apr 10, 2023
d755af6
Merge branch 'master' into users/chhol/update-fast-stable-package-ver…
chrisdholt Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-e7330a7e-73e6-4efd-a09f-84f488b8f917.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
chrisdholt marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 1 screenshots added, 0 screenshots removed, 1930 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 1 screenshots
Image Name Diff(in Pixels) Image Type
Badge Converged.width constrained.chromium.png 0 Added

"type": "patch",
"comment": "update fast foundation packages to import bug fixes",
"packageName": "@fluentui/web-components",
"email": "chhol@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"dependencies": {
"@microsoft/fast-colors": "^5.3.0",
"@microsoft/fast-element": "^1.11.0",
"@microsoft/fast-foundation": "^2.47.0",
"@microsoft/fast-foundation": "^2.48.0",
"@microsoft/fast-web-utilities": "^5.4.0",
"tslib": "^2.1.0"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/web-components/src/anchor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class Anchor extends FoundationAnchor {
* HTML Attribute: appearance
*/
@attr
public appearance: AnchorAppearance;
public appearance?: AnchorAppearance;
public appearanceChanged(oldValue: AnchorAppearance, newValue: AnchorAppearance): void {
if (oldValue !== newValue) {
this.classList.add(newValue);
Expand Down Expand Up @@ -50,9 +50,9 @@ export class Anchor extends FoundationAnchor {
const slottedElements = this.defaultSlottedContent.filter(x => x.nodeType === Node.ELEMENT_NODE);

if (slottedElements.length === 1 && slottedElements[0] instanceof SVGElement) {
this.control.classList.add('icon-only');
this.control?.classList.add('icon-only');
} else {
this.control.classList.remove('icon-only');
this.control?.classList.remove('icon-only');
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3054,10 +3054,10 @@
resolved "https://registry.yarnpkg.com/@microsoft/fast-element/-/fast-element-1.11.0.tgz#494f6c87057bcbb42406982d68a92887d6b5acb1"
integrity sha512-VKJYMkS5zgzHHb66sY7AFpYv6IfFhXrjQcAyNgi2ivD65My1XOhtjfKez5ELcLFRJfgZNAxvI8kE69apXERTkw==

"@microsoft/fast-foundation@^2.47.0":
version "2.47.0"
resolved "https://registry.yarnpkg.com/@microsoft/fast-foundation/-/fast-foundation-2.47.0.tgz#a4cc8c5277e21d080215f5adcaed4266a8dd8a8e"
integrity sha512-EyFuioaZQ9ngjUNRQi8R3dIPPsaNQdUOS+tP0G7b1MJRhXmQWIitBM6IeveQA6ZvXG6H21dqgrfEWlsYrUZ2sw==
"@microsoft/fast-foundation@^2.48.0":
version "2.48.0"
resolved "https://registry.yarnpkg.com/@microsoft/fast-foundation/-/fast-foundation-2.48.0.tgz#d0fcc333a1ed65a4f2d69d97247367600a35baca"
integrity sha512-kKrMq6oi16/BEL9UhjaZZcQ65BFYXBnIyzqkPlaG7AQ6afmQr33Azhfvx1yio77NjkWdpIUDhYrG/1qRz+VZKw==
dependencies:
"@microsoft/fast-element" "^1.11.0"
"@microsoft/fast-web-utilities" "^5.4.1"
Expand Down