Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update FAST dependencies to mitigate Safari 16.4 AdoptedStyleSheets bug #27578

Merged
merged 3 commits into from
Apr 15, 2023
Merged

update FAST dependencies to mitigate Safari 16.4 AdoptedStyleSheets bug #27578

merged 3 commits into from
Apr 15, 2023

Conversation

chrisdholt
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@chrisdholt chrisdholt requested review from a team as code owners April 14, 2023 19:31
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 88.978 kB
26.586 kB
react-alert
Alert		 95.877 kB
23.104 kB
react-avatar
Avatar		 59.542 kB
15.569 kB
react-avatar
AvatarGroup		 18.19 kB
6.706 kB
react-avatar
AvatarGroupItem		 75.803 kB
20.072 kB
react-badge
Badge		 26.075 kB
7.629 kB
react-badge
CounterBadge		 27.058 kB
7.938 kB
react-badge
PresenceBadge		 34.547 kB
8.726 kB
react-button
Button		 39.845 kB
10 kB
react-button
CompoundButton		 47.017 kB
11.469 kB
react-button
MenuButton		 44.532 kB
11.352 kB
react-button
SplitButton		 53.027 kB
12.914 kB
react-button
ToggleButton		 58.217 kB
11.922 kB
react-card
Card - All		 86.164 kB
24.342 kB
react-card
Card		 80.983 kB
22.881 kB
react-card
CardFooter		 9.122 kB
3.832 kB
react-card
CardHeader		 11.048 kB
4.537 kB
react-card
CardPreview		 9.927 kB
4.18 kB
react-checkbox
Checkbox		 37.109 kB
11.286 kB
react-combobox
Combobox (including child components)		 89.878 kB
28.552 kB
react-combobox
Dropdown (including child components)		 88.562 kB
28.275 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 68.093 kB
18.424 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.629 kB
57.6 kB
react-components
react-components: FluentProvider & webLightTheme		 38.833 kB
12.37 kB
react-datepicker-compat
DatePicker Compat		 251.37 kB
67.359 kB
react-dialog
Dialog (including children components)		 93.338 kB
27.391 kB
react-divider
Divider		 19.958 kB
6.736 kB
react-field
Field		 21.589 kB
7.453 kB
react-image
Image		 14.023 kB
5.008 kB
react-infobutton
InfoButton		 130.692 kB
39.476 kB
react-infobutton
InfoLabel		 133.988 kB
40.514 kB
react-input
Input		 26.796 kB
8.148 kB
react-label
Label		 12.657 kB
4.618 kB
react-link
Link		 12.313 kB
5.081 kB
react-menu
Menu (including children components)		 131.151 kB
39.687 kB
react-menu
Menu (including selectable components)		 134.287 kB
40.226 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 66.568 kB
17.513 kB
react-popover
Popover		 117.611 kB
35.839 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 16.409 kB
5.855 kB
react-provider
FluentProvider		 20.78 kB
7.135 kB
react-radio
Radio		 29.921 kB
9.118 kB
react-radio
RadioGroup		 13.952 kB
5.163 kB
react-select
Select		 28.004 kB
9.223 kB
react-slider
Slider		 36.934 kB
11.514 kB
react-spinbutton
SpinButton		 36.705 kB
10.792 kB
react-spinner
Spinner		 23.515 kB
7.226 kB
react-switch
Switch		 32.528 kB
9.73 kB
react-table
DataGrid		 150.956 kB
41.072 kB
react-table
Table (Primitives only)		 47.215 kB
12.749 kB
react-table
Table as DataGrid		 133.551 kB
33.685 kB
react-table
Table (Selection only)		 81.384 kB
19.67 kB
react-table
Table (Sort only)		 80.714 kB
19.479 kB
react-text
Text - Default		 15.03 kB
5.339 kB
react-text
Text - Wrappers		 15.584 kB
5.245 kB
react-textarea
Textarea		 30.203 kB
9.519 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 49.478 kB
16.853 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 97a9295c30393b604cf3c57923334a9b10d3b7d3

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 722 706 5000
Button mount 395 406 5000
Field mount 1278 1281 5000
FluentProvider mount 782 781 5000
FluentProviderWithTheme mount 107 108 10
FluentProviderWithTheme virtual-rerender 94 93 10
FluentProviderWithTheme virtual-rerender-with-unmount 97 105 10
InfoButton mount 19 18 5000
MakeStyles mount 1206 1227 50000
Persona mount 1952 1919 5000
SpinButton mount 1496 1503 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListCommonPerf.default 525 492 1.07:1
BoxMinimalPerf.default 257 242 1.06:1
FlexMinimalPerf.default 208 197 1.06:1
RadioGroupMinimalPerf.default 342 322 1.06:1
AttachmentMinimalPerf.default 104 99 1.05:1
AvatarMinimalPerf.default 138 132 1.05:1
ItemLayoutMinimalPerf.default 942 897 1.05:1
ProviderMinimalPerf.default 286 273 1.05:1
SegmentMinimalPerf.default 261 249 1.05:1
IconMinimalPerf.default 469 447 1.05:1
AttachmentSlotsPerf.default 852 818 1.04:1
DividerMinimalPerf.default 262 251 1.04:1
GridMinimalPerf.default 257 247 1.04:1
LayoutMinimalPerf.default 271 261 1.04:1
ListMinimalPerf.default 394 379 1.04:1
ReactionMinimalPerf.default 276 266 1.04:1
LoaderMinimalPerf.default 245 237 1.03:1
MenuButtonMinimalPerf.default 1291 1256 1.03:1
PopupMinimalPerf.default 456 441 1.03:1
ChatMinimalPerf.default 535 524 1.02:1
DatepickerMinimalPerf.default 4742 4634 1.02:1
HeaderSlotsPerf.default 584 572 1.02:1
ImageMinimalPerf.default 283 278 1.02:1
InputMinimalPerf.default 729 716 1.02:1
ListNestedPerf.default 417 407 1.02:1
ListWith60ListItems.default 477 466 1.02:1
MenuMinimalPerf.default 632 620 1.02:1
PortalMinimalPerf.default 117 115 1.02:1
ProviderMergeThemesPerf.default 1009 988 1.02:1
RefMinimalPerf.default 140 137 1.02:1
TextMinimalPerf.default 252 246 1.02:1
ToolbarMinimalPerf.default 667 654 1.02:1
TreeWith60ListItems.default 113 111 1.02:1
ButtonOverridesMissPerf.default 833 822 1.01:1
CardMinimalPerf.default 379 375 1.01:1
ChatDuplicateMessagesPerf.default 198 196 1.01:1
SliderMinimalPerf.default 917 904 1.01:1
TableMinimalPerf.default 294 292 1.01:1
TreeMinimalPerf.default 593 589 1.01:1
AlertMinimalPerf.default 191 191 1:1
ButtonMinimalPerf.default 108 108 1:1
DialogMinimalPerf.default 573 573 1:1
DropdownMinimalPerf.default 1837 1828 1:1
EmbedMinimalPerf.default 2378 2386 1:1
FormMinimalPerf.default 273 273 1:1
LabelMinimalPerf.default 284 285 1:1
RosterPerf.default 1819 1818 1:1
TableManyItemsPerf.default 1419 1426 1:1
TextAreaMinimalPerf.default 347 348 1:1
CustomToolbarPrototype.default 1916 1925 1:1
TooltipMinimalPerf.default 1640 1640 1:1
AnimationMinimalPerf.default 365 367 0.99:1
CheckboxMinimalPerf.default 1560 1574 0.99:1
HeaderMinimalPerf.default 256 259 0.99:1
SkeletonMinimalPerf.default 254 256 0.99:1
SplitButtonMinimalPerf.default 3025 3071 0.99:1
ButtonSlotsPerf.default 401 409 0.98:1
ChatWithPopoverPerf.default 239 247 0.97:1
DropdownManyItemsPerf.default 507 530 0.96:1
StatusMinimalPerf.default 489 507 0.96:1
CarouselMinimalPerf.default 335 351 0.95:1
VideoMinimalPerf.default 514 569 0.9:1
AccordionMinimalPerf.default 95 107 0.89:1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48bd359:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 14, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 97a9295c30393b604cf3c57923334a9b10d3b7d3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-deps-with-safari-bugfix branch from 6865abc to 10232d5 Compare April 14, 2023 20:02
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 796 796 5000
Breadcrumb mount 2046 2027 1000
Checkbox mount 2077 2081 5000
CheckboxBase mount 1858 1876 5000
ChoiceGroup mount 3565 3573 5000
ComboBox mount 795 771 1000
CommandBar mount 7783 7708 1000
ContextualMenu mount 12232 13721 1000
DefaultButton mount 941 921 5000
DetailsRow mount 2693 2661 5000
DetailsRowFast mount 2721 2656 5000
DetailsRowNoStyles mount 2472 2459 5000
Dialog mount 3213 3241 1000
DocumentCardTitle mount 286 290 1000
Dropdown mount 2464 2497 5000
FocusTrapZone mount 1428 1439 5000
FocusZone mount 1405 1394 5000
GroupedList mount 45608 45670 2
GroupedList virtual-rerender 22145 22182 2
GroupedList virtual-rerender-with-unmount 62222 62782 2
GroupedListV2 mount 276 280 2
GroupedListV2 virtual-rerender 261 262 2
GroupedListV2 virtual-rerender-with-unmount 285 284 2
IconButton mount 1303 1306 5000
Label mount 437 437 5000
Layer mount 3400 3385 5000
Link mount 518 513 5000
MenuButton mount 1132 1116 5000
MessageBar mount 25979 25792 5000
Nav mount 2358 2318 1000
OverflowSet mount 1006 997 5000
Panel mount 2182 2212 1000
Persona mount 910 921 1000
Pivot mount 1067 1038 1000
PrimaryButton mount 1061 1052 5000
Rating mount 5800 5779 5000
SearchBox mount 1128 1119 5000
Shimmer mount 2305 2342 5000
Slider mount 1659 1695 5000
SpinButton mount 3464 3454 5000
Spinner mount 517 503 5000
SplitButton mount 2211 2201 5000
Stack mount 527 527 5000
StackWithIntrinsicChildren mount 1082 1080 5000
StackWithTextChildren mount 3382 3363 5000
SwatchColorPicker mount 7408 7408 5000
TagPicker mount 1719 1727 5000
Text mount 491 482 5000
TextField mount 1154 1160 5000
ThemeProvider mount 1015 1024 5000
ThemeProvider virtual-rerender 796 784 5000
ThemeProvider virtual-rerender-with-unmount 1556 1563 5000
Toggle mount 793 786 5000
buttonNative mount 243 248 5000

@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-deps-with-safari-bugfix branch from 10232d5 to 47c2619 Compare April 14, 2023 20:08
@chrisdholt chrisdholt requested review from a team, spmonahan and micahgodbolt as code owners April 14, 2023 20:29
@chrisdholt chrisdholt merged commit 2e1cf89 into microsoft:master Apr 15, 2023
@chrisdholt chrisdholt deleted the users/chhol/update-fast-deps-with-safari-bugfix branch April 15, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spmonahan spmonahan spmonahan approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

Assignees

@smhigley smhigley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @fabricteam @nicholasrice @spmonahan @smhigley