Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST #5856 for wc - rows/cols for fluent-text-area #28135

Merged
merged 24 commits into from
Jul 19, 2023

Conversation

vnbaaij
Copy link
Contributor

@vnbaaij vnbaaij commented Jun 4, 2023

Previous Behavior

does not respond to setting row and/or cols attribute

New Behavior

does respond to setting row and/or cols attribute

Related Issue(s)

  • Fixes #

@size-auditor
Copy link

size-auditor bot commented Jun 4, 2023

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: f89bd49

Possible causes

  • The baseline build f89bd49 is broken
  • The Size Auditor run for the baseline build f89bd49 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 4, 2023

📊 Bundle size report

🤖 This report was generated against 32c30687b3351e088d10ddea296dca0628fd5a9f

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec5df01:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Ogglas
Copy link

Ogglas commented Jun 5, 2023

Probably relates to: #27842

@chrisdholt chrisdholt enabled auto-merge (squash) June 7, 2023 23:36
@chrisdholt chrisdholt disabled auto-merge June 9, 2023 03:37
@Ogglas
Copy link

Ogglas commented Jun 9, 2023

@chrisdholt @micahgodbolt Can this PR be merged?

@chrisdholt
Copy link
Member

@vnbaaij can you try and update/sync your branch with the latest from Fluent? Seems like there is likely a rebase issue happening causing issues with the build.

@chrisdholt chrisdholt enabled auto-merge (squash) June 10, 2023 18:08
@chrisdholt chrisdholt disabled auto-merge June 12, 2023 16:46
@Ogglas
Copy link

Ogglas commented Jun 16, 2023

Is anything more needed to merge this?

@chrisdholt
Copy link
Member

@micahgodbolt any idea why the build isn't running here at all?

@chrisdholt
Copy link
Member

@JustSlone The react build hasn't been running on @vnbaaij's PR since it was opened - is there perhaps some issue that can occur for contributors?

@JustSlone
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@chrisdholt chrisdholt merged commit 9e52c02 into microsoft:master Jul 19, 2023
@vnbaaij vnbaaij mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants