-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAST #5856 for wc - rows/cols for fluent-text-area #28135
Conversation
Asset size changesUnable to find bundle size details for Baseline commit: f89bd49 Possible causes
Recommendations
|
📊 Bundle size report🤖 This report was generated against 32c30687b3351e088d10ddea296dca0628fd5a9f |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec5df01:
|
Probably relates to: #27842 |
…e28135 adds change file for rows/cols
change/@fluentui-web-components-c8b4d98c-6c11-4728-b8db-a5e5e77f78da.json
Outdated
Show resolved
Hide resolved
@chrisdholt @micahgodbolt Can this PR be merged? |
@vnbaaij can you try and update/sync your branch with the latest from Fluent? Seems like there is likely a rebase issue happening causing issues with the build. |
Is anything more needed to merge this? |
@micahgodbolt any idea why the build isn't running here at all? |
@JustSlone The react build hasn't been running on @vnbaaij's PR since it was opened - is there perhaps some issue that can occur for contributors? |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Previous Behavior
does not respond to setting row and/or cols attribute
New Behavior
does respond to setting row and/or cols attribute
Related Issue(s)