Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useFocusVisible() to exports #29935

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

spmonahan
Copy link
Contributor

@spmonahan spmonahan commented Nov 29, 2023

Previous Behavior

react-tabster's useFocusVisible() hook was not re-exported from react-components

New Behavior

useFocusVisible() is exported from react-components.

Related Issue(s)

This helps teams using HeadlessProvider as they do not need to take a separate dependency on react-tabster.

@spmonahan spmonahan requested a review from a team as a code owner November 29, 2023 00:25
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 29, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 654 635 5000
Button mount 316 308 5000
Field mount 1127 1129 5000
FluentProvider mount 708 722 5000
FluentProviderWithTheme mount 83 82 10
FluentProviderWithTheme virtual-rerender 67 66 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 72 10
MakeStyles mount 869 882 50000
Persona mount 1756 1763 5000
SpinButton mount 1431 1406 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 29, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.816 kB
20.132 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.953 kB
59.48 kB
react-components
react-components: FluentProvider & webLightTheme
42.101 kB
13.957 kB
react-portal-compat
PortalCompatProvider
6.822 kB
2.311 kB
🤖 This report was generated against 69b1d233ce0fe10bd4d15a59ffdac6466d928e7d

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spmonahan you need to update an API file 😉

@spmonahan
Copy link
Contributor Author

@spmonahan you need to update an API file 😉

ack! knew I forgot something 😀

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f399668:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Copy link

size-auditor bot commented Nov 29, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 69b1d233ce0fe10bd4d15a59ffdac6466d928e7d (build)

@spmonahan spmonahan enabled auto-merge (squash) November 29, 2023 18:56
@spmonahan spmonahan merged commit 6438f49 into microsoft:master Nov 29, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants