-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add useFocusVisible() to exports #29935
feat: add useFocusVisible() to exports #29935
Conversation
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 654 | 635 | 5000 | |
Button | mount | 316 | 308 | 5000 | |
Field | mount | 1127 | 1129 | 5000 | |
FluentProvider | mount | 708 | 722 | 5000 | |
FluentProviderWithTheme | mount | 83 | 82 | 10 | |
FluentProviderWithTheme | virtual-rerender | 67 | 66 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 72 | 10 | |
MakeStyles | mount | 869 | 882 | 50000 | |
Persona | mount | 1756 | 1763 | 5000 | |
SpinButton | mount | 1431 | 1406 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spmonahan you need to update an API file 😉
ack! knew I forgot something 😀 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f399668:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 69b1d233ce0fe10bd4d15a59ffdac6466d928e7d (build) |
Previous Behavior
react-tabster
'suseFocusVisible()
hook was not re-exported fromreact-components
New Behavior
useFocusVisible()
is exported fromreact-components
.Related Issue(s)
This helps teams using HeadlessProvider as they do not need to take a separate dependency on
react-tabster
.