-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jest-axe from 6.0.1 to 8.0.0 #30309
Bump jest-axe from 6.0.1 to 8.0.0 #30309
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Here is the list of changes to axe-core from v4.4.1 to v4.7.2Deprecate not-html-matches, use :1.not(html) instead area-alt:
aria-allowed-role:
aria-hidden-focus:
aria-hidden-focusable:
aria-input-field-name:
aria-required-attr:
aria-required-children:
aria-required-parent:
aria-roledescription:
aria-roles:
aria-valid-attr-value:
autocomplete-valid:
avoid-inline-spacing:
axe.d.ts:
checks/label-content-name-mismatch:
checks/no-focusable-disable:
checks/unsupportedrole:
color-contrast:
color-contrast-enhanced:
commons:
context:
create-grid:
css-orientation-lock:
d.ts:
deprecatedrole,color-contrast:
dom.focusDisabled,dom.isVisibleForScreenreader:
empty-table-headers:
focus-order-semantics:
frame-focusable-content:
frame-title:
frame-title-unique:
get-role:
getRules:
html-elms:
html-lang-valid:
i18n:
identical-links-same-purpose:
input-image-alt:
is-hidden-for-everyone:
is-icon-ligature:
is-in-tab-order:
is-visible-on-screen:
label:
label,select-name:
link-in-text-block:
list,listitem:
list/definition-list:
meta-refresh:
meta-viewport:
metadata:
new rule:
no-autoplay-audio:
object-alt:
page-has-heading-one,landmark-one-main:
presentation-role-conflict:
required-attr:
respondable:
scrollable-region-focusable:
standards:
tags:
td-headers-attr:
utils:
utils.matches:
valid-lang:
video-caption:
|
Changes in jest-axe from 6.0.1 to 8.0.0
Breaking changes
|
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 634 | 652 | 5000 | |
Button | mount | 301 | 302 | 5000 | |
Field | mount | 1100 | 1162 | 5000 | |
FluentProvider | mount | 686 | 709 | 5000 | |
FluentProviderWithTheme | mount | 75 | 84 | 10 | |
FluentProviderWithTheme | virtual-rerender | 68 | 65 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 86 | 10 | |
MakeStyles | mount | 863 | 862 | 50000 | |
Persona | mount | 1774 | 1741 | 5000 | |
SpinButton | mount | 1343 | 1396 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AccordionMinimalPerf.default | 89 | 74 | 1.2:1 |
ButtonMinimalPerf.default | 98 | 86 | 1.14:1 |
LoaderMinimalPerf.default | 209 | 183 | 1.14:1 |
ImageMinimalPerf.default | 231 | 206 | 1.12:1 |
GridMinimalPerf.default | 200 | 182 | 1.1:1 |
IconMinimalPerf.default | 402 | 366 | 1.1:1 |
TreeWith60ListItems.default | 89 | 81 | 1.1:1 |
ChatMinimalPerf.default | 461 | 423 | 1.09:1 |
FormMinimalPerf.default | 236 | 217 | 1.09:1 |
BoxMinimalPerf.default | 208 | 193 | 1.08:1 |
AlertMinimalPerf.default | 163 | 152 | 1.07:1 |
AvatarMinimalPerf.default | 114 | 107 | 1.07:1 |
DatepickerMinimalPerf.default | 3773 | 3535 | 1.07:1 |
CarouselMinimalPerf.default | 263 | 248 | 1.06:1 |
ListNestedPerf.default | 335 | 315 | 1.06:1 |
FlexMinimalPerf.default | 162 | 155 | 1.05:1 |
LabelMinimalPerf.default | 226 | 216 | 1.05:1 |
RefMinimalPerf.default | 119 | 113 | 1.05:1 |
SegmentMinimalPerf.default | 198 | 188 | 1.05:1 |
ItemLayoutMinimalPerf.default | 724 | 699 | 1.04:1 |
SkeletonMinimalPerf.default | 201 | 193 | 1.04:1 |
ChatWithPopoverPerf.default | 196 | 191 | 1.03:1 |
HeaderMinimalPerf.default | 206 | 200 | 1.03:1 |
InputMinimalPerf.default | 546 | 528 | 1.03:1 |
TextMinimalPerf.default | 193 | 187 | 1.03:1 |
ToolbarMinimalPerf.default | 543 | 527 | 1.03:1 |
DividerMinimalPerf.default | 205 | 200 | 1.02:1 |
DropdownMinimalPerf.default | 1428 | 1395 | 1.02:1 |
HeaderSlotsPerf.default | 473 | 464 | 1.02:1 |
ProviderMinimalPerf.default | 201 | 197 | 1.02:1 |
SplitButtonMinimalPerf.default | 2251 | 2207 | 1.02:1 |
VideoMinimalPerf.default | 440 | 433 | 1.02:1 |
AttachmentMinimalPerf.default | 82 | 81 | 1.01:1 |
ButtonSlotsPerf.default | 304 | 301 | 1.01:1 |
DropdownManyItemsPerf.default | 403 | 398 | 1.01:1 |
EmbedMinimalPerf.default | 1858 | 1835 | 1.01:1 |
MenuMinimalPerf.default | 505 | 502 | 1.01:1 |
MenuButtonMinimalPerf.default | 943 | 934 | 1.01:1 |
PortalMinimalPerf.default | 85 | 84 | 1.01:1 |
TableMinimalPerf.default | 239 | 236 | 1.01:1 |
TextAreaMinimalPerf.default | 279 | 275 | 1.01:1 |
TooltipMinimalPerf.default | 1261 | 1247 | 1.01:1 |
ButtonOverridesMissPerf.default | 657 | 660 | 1:1 |
CheckboxMinimalPerf.default | 1114 | 1114 | 1:1 |
DialogMinimalPerf.default | 430 | 432 | 1:1 |
LayoutMinimalPerf.default | 194 | 194 | 1:1 |
ListMinimalPerf.default | 306 | 305 | 1:1 |
SliderMinimalPerf.default | 734 | 735 | 1:1 |
StatusMinimalPerf.default | 396 | 395 | 1:1 |
CustomToolbarPrototype.default | 1461 | 1459 | 1:1 |
ListCommonPerf.default | 382 | 387 | 0.99:1 |
ProviderMergeThemesPerf.default | 643 | 652 | 0.99:1 |
RadioGroupMinimalPerf.default | 258 | 260 | 0.99:1 |
TableManyItemsPerf.default | 1089 | 1098 | 0.99:1 |
TreeMinimalPerf.default | 465 | 471 | 0.99:1 |
AnimationMinimalPerf.default | 295 | 301 | 0.98:1 |
AttachmentSlotsPerf.default | 622 | 636 | 0.98:1 |
ChatDuplicateMessagesPerf.default | 145 | 150 | 0.97:1 |
RosterPerf.default | 1522 | 1572 | 0.97:1 |
PopupMinimalPerf.default | 346 | 360 | 0.96:1 |
ReactionMinimalPerf.default | 218 | 228 | 0.96:1 |
CardMinimalPerf.default | 301 | 317 | 0.95:1 |
ListWith60ListItems.default | 342 | 364 | 0.94:1 |
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 28dc7702fd80cb04c6b0cf7617d55ba5213616e3 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 621 | 625 | 5000 | |
Breadcrumb | mount | 1667 | 1667 | 1000 | |
Checkbox | mount | 1658 | 1677 | 5000 | |
CheckboxBase | mount | 1518 | 1456 | 5000 | |
ChoiceGroup | mount | 2938 | 2982 | 5000 | |
ComboBox | mount | 656 | 642 | 1000 | |
CommandBar | mount | 6189 | 6202 | 1000 | |
ContextualMenu | mount | 12210 | 12193 | 1000 | |
DefaultButton | mount | 736 | 753 | 5000 | |
DetailsRow | mount | 2179 | 2182 | 5000 | |
DetailsRowFast | mount | 2241 | 2176 | 5000 | |
DetailsRowNoStyles | mount | 2029 | 2063 | 5000 | |
Dialog | mount | 2807 | 2632 | 1000 | |
DocumentCardTitle | mount | 226 | 221 | 1000 | |
Dropdown | mount | 1973 | 1962 | 5000 | |
FocusTrapZone | mount | 1160 | 1120 | 5000 | |
FocusZone | mount | 1066 | 1093 | 5000 | |
GroupedList | mount | 41626 | 41476 | 2 | |
GroupedList | virtual-rerender | 19962 | 19913 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50739 | 50663 | 2 | |
GroupedListV2 | mount | 235 | 216 | 2 | |
GroupedListV2 | virtual-rerender | 212 | 209 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 218 | 228 | 2 | |
IconButton | mount | 1080 | 1066 | 5000 | |
Label | mount | 333 | 333 | 5000 | |
Layer | mount | 2734 | 2771 | 5000 | |
Link | mount | 392 | 400 | 5000 | |
MenuButton | mount | 968 | 945 | 5000 | |
MessageBar | mount | 21497 | 21521 | 5000 | |
Nav | mount | 1910 | 1909 | 1000 | |
OverflowSet | mount | 773 | 798 | 5000 | |
Panel | mount | 1777 | 1800 | 1000 | |
Persona | mount | 721 | 753 | 1000 | |
Pivot | mount | 874 | 862 | 1000 | |
PrimaryButton | mount | 847 | 857 | 5000 | |
Rating | mount | 4595 | 4608 | 5000 | |
SearchBox | mount | 924 | 899 | 5000 | |
Shimmer | mount | 1845 | 1898 | 5000 | |
Slider | mount | 1329 | 1300 | 5000 | |
SpinButton | mount | 2864 | 2902 | 5000 | |
Spinner | mount | 406 | 383 | 5000 | |
SplitButton | mount | 1793 | 1827 | 5000 | |
Stack | mount | 407 | 417 | 5000 | |
StackWithIntrinsicChildren | mount | 846 | 867 | 5000 | |
StackWithTextChildren | mount | 2591 | 2563 | 5000 | |
SwatchColorPicker | mount | 6116 | 6021 | 5000 | |
TagPicker | mount | 1433 | 1468 | 5000 | |
Text | mount | 366 | 372 | 5000 | |
TextField | mount | 924 | 936 | 5000 | |
ThemeProvider | mount | 817 | 818 | 5000 | |
ThemeProvider | virtual-rerender | 601 | 580 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1281 | 1287 | 5000 | |
Toggle | mount | 618 | 614 | 5000 | |
buttonNative | mount | 193 | 199 | 5000 |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
@Shubhabrata08 Could you pull latest master and resolve the merge conflict |
Ok |
…ump-jest-axe-charting
@AtishayMsft Merged latest changes |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
🕵 fluentuiv8 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
@Shubhabrata08 This change is merged now. Thanks for the contribution. |
Happy to help 👍 |
Previous Behavior
jest-axe for FluentUI was at v6.0.1
New Behavior
jest-axe for FluentUI bumped up to 8.0.0
This ensures all further developments in FluentUI that use jest-axe for accessibility testing are in compliance with the latest axe-core rules supported by jest-axe.
Here's a demo test:
The test fails in jest-axe 6.0.1
The test passes in jest-axe 8.0.0 as an exception for 20+ hour time values was added for meta refresh tags and a no-exception optional rule was added to axe-core.
Related Issue(s)