Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export design token from rollup bundle #30784

Conversation

chrisdholt
Copy link
Member

Previous Behavior

Users of the CDN and rollup bundle cannot create or implement their own custom design tokens.

New Behavior

This PR exports DesignToken as part of the bundle to enable that behavior.

@chrisdholt chrisdholt requested a review from a team as a code owner March 14, 2024 18:12
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 14, 2024

📊 Bundle size report

🤖 This report was generated against 01721416e3753e85cfc3f19fccf0815add5d370a

Copy link

codesandbox-ci bot commented Mar 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tlmii
Copy link
Member

tlmii commented Mar 25, 2024

@chrisdholt Just curious if there's anything blocking this going in? I know there's a lot of steps to go before this will be available to FluentUI-Blazor folks, so just hoping it can move forward when possible.

@chrisdholt
Copy link
Member Author

@chrisdholt Just curious if there's anything blocking this going in? I know there's a lot of steps to go before this will be available to FluentUI-Blazor folks, so just hoping it can move forward when possible.

Just need sign-off from @microsoft/fui-wc

@chrisdholt chrisdholt enabled auto-merge (squash) March 26, 2024 17:46
@chrisdholt chrisdholt merged commit 80f3ae2 into microsoft:master Mar 26, 2024
18 checks passed
robertpenner pushed a commit to robertpenner/fluentui that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants