TeachingPopover: New Carousel and minor styling fixes #30998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 643 | 639 | 5000 | |
| Button | mount | 308 | 313 | 5000 | |
| Field | mount | 1114 | 1124 | 5000 | |
| FluentProvider | mount | 719 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 78 | 10 | |
| MakeStyles | mount | 878 | 879 | 50000 | |
| Persona | mount | 1808 | 1726 | 5000 | |
| SpinButton | mount | 1410 | 1354 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| PortalMinimalPerf.default | 89 | 87 | 1.02:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 211 | 182 | 1.16:1 |
| AttachmentMinimalPerf.default | 86 | 75 | 1.15:1 |
| LoaderMinimalPerf.default | 200 | 180 | 1.11:1 |
| GridMinimalPerf.default | 203 | 185 | 1.1:1 |
| AvatarMinimalPerf.default | 112 | 103 | 1.09:1 |
| ButtonMinimalPerf.default | 89 | 82 | 1.09:1 |
| DividerMinimalPerf.default | 216 | 199 | 1.09:1 |
| CarouselMinimalPerf.default | 275 | 256 | 1.07:1 |
| FormMinimalPerf.default | 228 | 214 | 1.07:1 |
| ReactionMinimalPerf.default | 216 | 201 | 1.07:1 |
| SkeletonMinimalPerf.default | 207 | 194 | 1.07:1 |
| AnimationMinimalPerf.default | 317 | 299 | 1.06:1 |
| RefMinimalPerf.default | 112 | 106 | 1.06:1 |
| AccordionMinimalPerf.default | 87 | 83 | 1.05:1 |
| IconMinimalPerf.default | 395 | 376 | 1.05:1 |
| TableManyItemsPerf.default | 1138 | 1088 | 1.05:1 |
| HeaderMinimalPerf.default | 221 | 212 | 1.04:1 |
| ListCommonPerf.default | 385 | 369 | 1.04:1 |
| ListMinimalPerf.default | 315 | 304 | 1.04:1 |
| ButtonSlotsPerf.default | 311 | 303 | 1.03:1 |
| InputMinimalPerf.default | 530 | 513 | 1.03:1 |
| LabelMinimalPerf.default | 224 | 218 | 1.03:1 |
| ListNestedPerf.default | 334 | 324 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2312 | 2248 | 1.03:1 |
| CardMinimalPerf.default | 308 | 302 | 1.02:1 |
| DatepickerMinimalPerf.default | 3656 | 3579 | 1.02:1 |
| DialogMinimalPerf.default | 453 | 442 | 1.02:1 |
| EmbedMinimalPerf.default | 1897 | 1854 | 1.02:1 |
| MenuMinimalPerf.default | 508 | 496 | 1.02:1 |
| TextMinimalPerf.default | 198 | 195 | 1.02:1 |
| ToolbarMinimalPerf.default | 543 | 534 | 1.02:1 |
| TooltipMinimalPerf.default | 1269 | 1248 | 1.02:1 |
| CheckboxMinimalPerf.default | 1134 | 1124 | 1.01:1 |
| FlexMinimalPerf.default | 160 | 159 | 1.01:1 |
| ImageMinimalPerf.default | 221 | 218 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 701 | 692 | 1.01:1 |
| VideoMinimalPerf.default | 434 | 429 | 1.01:1 |
| AlertMinimalPerf.default | 159 | 159 | 1:1 |
| ChatMinimalPerf.default | 446 | 444 | 1:1 |
| PopupMinimalPerf.default | 357 | 358 | 1:1 |
| SegmentMinimalPerf.default | 199 | 199 | 1:1 |
| TableMinimalPerf.default | 229 | 228 | 1:1 |
| CustomToolbarPrototype.default | 1468 | 1473 | 1:1 |
| TreeMinimalPerf.default | 485 | 487 | 1:1 |
| AttachmentSlotsPerf.default | 664 | 671 | 0.99:1 |
| BoxMinimalPerf.default | 193 | 194 | 0.99:1 |
| ButtonOverridesMissPerf.default | 650 | 656 | 0.99:1 |
| DropdownMinimalPerf.default | 1445 | 1453 | 0.99:1 |
| MenuButtonMinimalPerf.default | 955 | 967 | 0.99:1 |
| ProviderMergeThemesPerf.default | 637 | 641 | 0.99:1 |
| RadioGroupMinimalPerf.default | 266 | 268 | 0.99:1 |
| SliderMinimalPerf.default | 744 | 749 | 0.99:1 |
| StatusMinimalPerf.default | 390 | 392 | 0.99:1 |
| HeaderSlotsPerf.default | 460 | 469 | 0.98:1 |
| LayoutMinimalPerf.default | 208 | 213 | 0.98:1 |
| TextAreaMinimalPerf.default | 283 | 289 | 0.98:1 |
| TreeWith60ListItems.default | 91 | 93 | 0.98:1 |
| DropdownManyItemsPerf.default | 390 | 404 | 0.97:1 |
| ListWith60ListItems.default | 367 | 378 | 0.97:1 |
| ProviderMinimalPerf.default | 196 | 202 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 146 | 153 | 0.95:1 |
| RosterPerf.default | 1511 | 1587 | 0.95:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 638 | 664 | 5000 | |
| Breadcrumb | mount | 1723 | 1721 | 1000 | |
| Checkbox | mount | 1748 | 1756 | 5000 | |
| CheckboxBase | mount | 1486 | 1475 | 5000 | |
| ChoiceGroup | mount | 2938 | 2911 | 5000 | |
| ComboBox | mount | 663 | 646 | 1000 | |
| CommandBar | mount | 6355 | 6270 | 1000 | |
| ContextualMenu | mount | 13184 | 13647 | 1000 | |
| DefaultButton | mount | 785 | 792 | 5000 | |
| DetailsRow | mount | 2248 | 2240 | 5000 | |
| DetailsRowFast | mount | 2239 | 2214 | 5000 | |
| DetailsRowNoStyles | mount | 2044 | 2046 | 5000 | |
| Dialog | mount | 2774 | 2728 | 1000 | |
| DocumentCardTitle | mount | 233 | 230 | 1000 | |
| Dropdown | mount | 2006 | 2033 | 5000 | |
| FocusTrapZone | mount | 1171 | 1161 | 5000 | |
| FocusZone | mount | 1128 | 1088 | 5000 | |
| GroupedList | mount | 43572 | 43416 | 2 | |
| GroupedList | virtual-rerender | 20648 | 20956 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52054 | 52180 | 2 | |
| GroupedListV2 | mount | 234 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 217 | 222 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 238 | 243 | 2 | |
| IconButton | mount | 1112 | 1155 | 5000 | |
| Label | mount | 336 | 333 | 5000 | |
| Layer | mount | 2780 | 2742 | 5000 | |
| Link | mount | 390 | 396 | 5000 | |
| MenuButton | mount | 923 | 961 | 5000 | |
| MessageBar | mount | 21665 | 21401 | 5000 | |
| Nav | mount | 2019 | 1996 | 1000 | |
| OverflowSet | mount | 789 | 796 | 5000 | |
| Panel | mount | 1811 | 1800 | 1000 | |
| Persona | mount | 749 | 759 | 1000 | |
| Pivot | mount | 881 | 901 | 1000 | |
| PrimaryButton | mount | 874 | 866 | 5000 | |
| Rating | mount | 4724 | 4777 | 5000 | |
| SearchBox | mount | 924 | 963 | 5000 | |
| Shimmer | mount | 1924 | 1967 | 5000 | |
| Slider | mount | 1375 | 1391 | 5000 | |
| SpinButton | mount | 2950 | 2968 | 5000 | |
| Spinner | mount | 404 | 404 | 5000 | |
| SplitButton | mount | 1875 | 1885 | 5000 | |
| Stack | mount | 428 | 424 | 5000 | |
| StackWithIntrinsicChildren | mount | 882 | 905 | 5000 | |
| StackWithTextChildren | mount | 2703 | 2624 | 5000 | |
| SwatchColorPicker | mount | 6305 | 6375 | 5000 | |
| TagPicker | mount | 1519 | 1460 | 5000 | |
| Text | mount | 361 | 381 | 5000 | |
| TextField | mount | 959 | 953 | 5000 | |
| ThemeProvider | mount | 868 | 845 | 5000 | |
| ThemeProvider | virtual-rerender | 604 | 583 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1284 | 1291 | 5000 | |
| Toggle | mount | 627 | 627 | 5000 | |
| buttonNative | mount | 212 | 193 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Apr 9, 2024
...eaching-popover-preview/src/components/TeachingPopoverCarousel/Carousel/useCarouselWalker.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Apr 15, 2024
.../react-teaching-popover-preview/src/components/TeachingPopoverCarousel/Carousel/constants.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Apr 15, 2024
...hing-popover-preview/src/components/TeachingPopoverCarousel/TeachingPopoverCarousel.types.ts
Show resolved
Hide resolved
🕵 FluentUIV0 No visual regressions between this PR and main |
...over-preview/src/components/TeachingPopoverCarousel/Carousel/CarouselItem/useCarouselItem.ts
Show resolved
Hide resolved
...rc/components/TeachingPopoverCarouselFooter/useTeachingPopoverCarouselFooterStyles.styles.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Apr 16, 2024
mltejera
approved these changes
Apr 16, 2024
ling1726
approved these changes
Apr 16, 2024
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Apr 17, 2024
Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Teaching popover carousel relied on accessing the children array and took direct children as pages.
New Behavior
Pages are now uniquely identified by the TeachingPopoverBody regardless of DOM structure, and the children array access is no longer required.
Also fixed styling and interface issues present (listed below).
Related Issue(s)
TeachingPopoverCarousel needsto iterate react children to function correctly #30928
TeachingPopoverCarousel - onPageChange is called twice for each page change #30932
TeachingPopoverCarousel unable to override pageCount #30931
TeachingPopoverCarousel - unable to override Nav component #30930