feat(react-nav-preview): Applying styles to NavCategoryItem and NavSubItem #31019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mltejera
force-pushed
the
user/matejera/nav-mega-style
branch
from
32f5283 to
b6015fc
Compare
|
Looking good! Wondering if the chevron direction has been set yet? We're using right-direction for closed, then down-direction for open. In addition, it looks like the chevron makes a little jump to the left when the NavCategoryItem opens. |
|
Good catch on the icon - updated! |
...s/react-components/react-nav-preview/src/components/NavCategoryItem/NavCategoryItem.types.ts
Show resolved
Hide resolved
...s/react-components/react-nav-preview/src/components/NavCategoryItem/NavCategoryItem.types.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-nav-preview/src/components/NavCategoryItem/renderNavCategoryItem.tsx
Show resolved
Hide resolved
...act-components/react-nav-preview/src/components/NavCategoryItem/useNavCategoryItem.styles.ts
Outdated
Show resolved
Hide resolved
...act-components/react-nav-preview/src/components/NavCategoryItem/useNavCategoryItem.styles.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-nav-preview/src/components/NavCategoryItem/renderNavCategoryItem.tsx
Show resolved
Hide resolved
packages/react-components/react-nav-preview/src/components/sharedNavStyles.styles.ts
Outdated
Show resolved
Hide resolved
mltejera
force-pushed
the
user/matejera/nav-mega-style
branch
from
4529ba5 to
e31efc9
Compare
...act-components/react-nav-preview/src/components/NavCategoryItem/useNavCategoryItem.styles.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
approved these changes
Apr 15, 2024
sopranopillow
approved these changes
Apr 16, 2024
...s/react-components/react-nav-preview/src/components/NavCategoryItem/NavCategoryItem.types.ts
Outdated
Show resolved
Hide resolved
...act-components/react-nav-preview/src/components/NavCategoryItem/useNavCategoryItem.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-nav-preview/src/components/NavItem/useNavItemStyles.styles.ts
Show resolved
Hide resolved
...s/react-components/react-nav-preview/src/components/NavSubItem/useNavSubItemStyles.styles.ts
Outdated
Show resolved
Hide resolved
|
updated all the import statements, thanks Esteban! |
mltejera
force-pushed
the
user/matejera/nav-mega-style
branch
from
5530a6b to
43df8c9
Compare
mltejera
force-pushed
the
user/matejera/nav-mega-style
branch
from
43df8c9 to
5648091
Compare
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the lessons learned from styling the NavItem and applied them to NavCategoryItem and NavSubItem.
Open Question - Since I plan for these styles to be intentionally shared, so I move them to some sort of 'SharedNavStyles" folder to be more clear about intentionality?
Chips away at #26649
Recording.2024-04-11.090742.mp4