Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move tabindex to the root slot of Spinner #31056

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

tomi-msft
Copy link
Contributor

Fixes #31025

@tomi-msft tomi-msft requested a review from a team as a code owner April 15, 2024 20:37
@tomi-msft tomi-msft self-assigned this Apr 15, 2024
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 15, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 15, 2024

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 33 36 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 625 645 5000
Button mount 293 306 5000
Field mount 1126 1162 5000
FluentProvider mount 709 702 5000
FluentProviderWithTheme mount 80 82 10
FluentProviderWithTheme virtual-rerender 33 36 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 74 73 10
MakeStyles mount 848 852 50000
Persona mount 1766 1720 5000
SpinButton mount 1384 1381 5000

Copy link

codesandbox-ci bot commented Apr 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 15, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-spinner
Spinner
24.71 kB
8.35 kB
24.673 kB
8.341 kB
-37 B
-9 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
71.104 kB
20.52 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.141 kB
62.432 kB
react-components
react-components: FluentProvider & webLightTheme
43.591 kB
14.356 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
🤖 This report was generated against 6441cd2b0654e1b1404c5c3bcea59c7c66d9617a

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 15, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, otherwise looks good!

@tomi-msft tomi-msft merged commit d38059f into microsoft:master Apr 16, 2024
19 checks passed
@tomi-msft tomi-msft deleted the spinner-tabindex-update branch April 16, 2024 20:12
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Spinner focusing and screen readers issues
4 participants