Refactoring the utilities to reduce monosize of components #31291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmukher
changed the title
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
May 7, 2024
change/@fluentui-react-charting-4903549d-4b4c-4971-bfce-c488ad145a47.json
Show resolved
Hide resolved
AtishayMsft
reviewed
May 7, 2024
packages/react-charting/src/components/AreaChart/__snapshots__/AreaChart.test.tsx.snap
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 7, 2024
packages/react-charting/src/components/CommonComponents/CartesianChart.types.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 7, 2024
packages/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
May 7, 2024
packages/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
Outdated
Show resolved
Hide resolved
|
Can you update the PR description to represent only the changes in this PR. |
AtishayMsft
reviewed
May 14, 2024
change/@fluentui-react-charting-4903549d-4b4c-4971-bfce-c488ad145a47.json
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 14, 2024
packages/react-charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 14, 2024
packages/react-charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 14, 2024
packages/react-charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
May 14, 2024
AtishayMsft
reviewed
May 14, 2024
packages/react-charting/src/components/HeatMapChart/HeatMapChart.base.tsx
Outdated
Show resolved
Hide resolved
srmukher
force-pushed
the
users/srmukher/RefactorUtils
branch
from
d2dc25f
to
d023c9b
Compare
AtishayMsft
reviewed
May 16, 2024
AtishayMsft
reviewed
May 16, 2024
packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
|
Performed Full test pass on this PR https://fluentuipr.z22.web.core.windows.net/pull/31291/public-docsite/index.html#/controls. |
AtishayMsft
reviewed
May 28, 2024
packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
approved these changes
May 29, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the utilities to remove indirect function invocations. This reduced the monosize of each cartesian components by 4kB on an average.
