-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(react-motions): AtomMotionFn & PresenceMotionFn have an object as param #31508
Merged
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/motion-element
Jun 4, 2024
Merged
breaking(react-motions): AtomMotionFn & PresenceMotionFn have an object as param #31508
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/motion-element
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 40 | 31 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 622 | 661 | 5000 | |
Button | mount | 316 | 302 | 5000 | |
Field | mount | 1139 | 1177 | 5000 | |
FluentProvider | mount | 708 | 719 | 5000 | |
FluentProviderWithTheme | mount | 87 | 94 | 10 | |
FluentProviderWithTheme | virtual-rerender | 40 | 31 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 76 | 10 | |
MakeStyles | mount | 878 | 854 | 50000 | |
Persona | mount | 1804 | 1698 | 5000 | |
SpinButton | mount | 1395 | 1380 | 5000 | |
SwatchPicker | mount | 1556 | 1547 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
chore/motion-element
branch
from
May 29, 2024 14:18
4696308
to
8802ba1
Compare
robertpenner
approved these changes
May 29, 2024
fabricteam
reviewed
May 29, 2024
change/@fluentui-react-motions-preview-f7e0f94c-24bd-4fa0-bae2-886019aac40f.json
Show resolved
Hide resolved
ling1726
reviewed
May 29, 2024
ling1726
approved these changes
May 29, 2024
layershifter
force-pushed
the
chore/motion-element
branch
from
June 4, 2024 14:52
8802ba1
to
b33d58f
Compare
layershifter
force-pushed
the
chore/motion-element
branch
from
June 4, 2024 15:27
b33d58f
to
91be1e3
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
This PR changes
AtomMotionFn
&PresenceMotionFn
:The motivation is to have an opportunity to extend it with additional params while
element
may not be used i.e.:Previous Behavior
New Behavior