Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update repo LICENSE #31560

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: update repo LICENSE #31560

merged 1 commit into from
Jun 6, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 4, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 4, 2024
@Hotell Hotell marked this pull request as ready for review June 4, 2024 10:50
@Hotell Hotell enabled auto-merge (squash) June 4, 2024 10:51
fabricteam
fabricteam reviewed Jun 4, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 647 655 5000
Button mount 301 296 5000
Field mount 1098 1081 5000
FluentProvider mount 711 725 5000
FluentProviderWithTheme mount 84 81 10
FluentProviderWithTheme virtual-rerender 32 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 82 73 10
MakeStyles mount 858 876 50000
Persona mount 1779 1767 5000
SpinButton mount 1358 1450 5000
SwatchPicker mount 1547 1561 5000

fabricteam
fabricteam reviewed Jun 4, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 100 81 1.23:1
RefMinimalPerf.default 119 103 1.16:1
AttachmentMinimalPerf.default 93 81 1.15:1
ChatDuplicateMessagesPerf.default 172 152 1.13:1
FormMinimalPerf.default 233 213 1.09:1
DatepickerMinimalPerf.default 3733 3527 1.06:1
ItemLayoutMinimalPerf.default 736 697 1.06:1
ProviderMinimalPerf.default 210 198 1.06:1
DividerMinimalPerf.default 219 208 1.05:1
HeaderSlotsPerf.default 483 461 1.05:1
PortalMinimalPerf.default 89 85 1.05:1
IconMinimalPerf.default 420 401 1.05:1
ListMinimalPerf.default 312 301 1.04:1
AvatarMinimalPerf.default 111 108 1.03:1
ChatWithPopoverPerf.default 204 199 1.03:1
ImageMinimalPerf.default 230 223 1.03:1
ListNestedPerf.default 338 328 1.03:1
RadioGroupMinimalPerf.default 269 262 1.03:1
TreeMinimalPerf.default 491 478 1.03:1
AnimationMinimalPerf.default 311 305 1.02:1
AttachmentSlotsPerf.default 661 646 1.02:1
BoxMinimalPerf.default 194 191 1.02:1
DialogMinimalPerf.default 449 440 1.02:1
DropdownMinimalPerf.default 1469 1442 1.02:1
InputMinimalPerf.default 547 538 1.02:1
ListWith60ListItems.default 383 375 1.02:1
SegmentMinimalPerf.default 197 194 1.02:1
SkeletonMinimalPerf.default 199 196 1.02:1
SliderMinimalPerf.default 748 733 1.02:1
TableMinimalPerf.default 246 240 1.02:1
TooltipMinimalPerf.default 1306 1276 1.02:1
AccordionMinimalPerf.default 90 89 1.01:1
EmbedMinimalPerf.default 1898 1878 1.01:1
LoaderMinimalPerf.default 195 194 1.01:1
MenuButtonMinimalPerf.default 963 950 1.01:1
ProviderMergeThemesPerf.default 652 648 1.01:1
ReactionMinimalPerf.default 220 217 1.01:1
TableManyItemsPerf.default 1113 1100 1.01:1
TextMinimalPerf.default 198 196 1.01:1
TextAreaMinimalPerf.default 289 286 1.01:1
CarouselMinimalPerf.default 264 264 1:1
ChatMinimalPerf.default 445 444 1:1
CheckboxMinimalPerf.default 1171 1167 1:1
DropdownManyItemsPerf.default 393 394 1:1
FlexMinimalPerf.default 148 148 1:1
LabelMinimalPerf.default 226 225 1:1
CustomToolbarPrototype.default 1526 1521 1:1
VideoMinimalPerf.default 449 447 1:1
AlertMinimalPerf.default 154 155 0.99:1
ButtonOverridesMissPerf.default 651 659 0.99:1
ButtonSlotsPerf.default 310 312 0.99:1
RosterPerf.default 1614 1638 0.99:1
CardMinimalPerf.default 311 317 0.98:1
GridMinimalPerf.default 187 190 0.98:1
ListCommonPerf.default 381 388 0.98:1
MenuMinimalPerf.default 508 520 0.98:1
PopupMinimalPerf.default 353 361 0.98:1
HeaderMinimalPerf.default 202 209 0.97:1
LayoutMinimalPerf.default 194 201 0.97:1
SplitButtonMinimalPerf.default 2254 2315 0.97:1
StatusMinimalPerf.default 392 405 0.97:1
ToolbarMinimalPerf.default 543 565 0.96:1
ButtonMinimalPerf.default 82 93 0.88:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 635 5000
Breadcrumb mount 1692 1749 1000
Checkbox mount 1704 1699 5000
CheckboxBase mount 1468 1477 5000
ChoiceGroup mount 2952 2968 5000
ComboBox mount 664 685 1000
CommandBar mount 6512 6533 1000
ContextualMenu mount 14422 14622 1000
DefaultButton mount 791 784 5000
DetailsRow mount 2213 2224 5000
DetailsRowFast mount 2203 2187 5000
DetailsRowNoStyles mount 2024 2014 5000
Dialog mount 2671 2590 1000
DocumentCardTitle mount 231 223 1000
Dropdown mount 1976 2016 5000
FocusTrapZone mount 1119 1133 5000
FocusZone mount 1045 1097 5000
GroupedList mount 37670 42479 2
GroupedList virtual-rerender 20075 20238 2
GroupedList virtual-rerender-with-unmount 51635 51021 2
GroupedListV2 mount 223 233 2
GroupedListV2 virtual-rerender 215 203 2
GroupedListV2 virtual-rerender-with-unmount 236 231 2
IconButton mount 1120 1145 5000
Label mount 342 337 5000
Layer mount 2781 2766 5000
Link mount 390 399 5000
MenuButton mount 970 969 5000
MessageBar mount 21518 21636 5000
Nav mount 2053 2002 1000
OverflowSet mount 783 785 5000
Panel mount 1783 1765 1000
Persona mount 728 741 1000
Pivot mount 912 922 1000
PrimaryButton mount 926 941 5000
Rating mount 4644 4753 5000
SearchBox mount 898 921 5000
Shimmer mount 1890 1916 5000
Slider mount 1333 1331 5000
SpinButton mount 2943 3000 5000
Spinner mount 399 406 5000
SplitButton mount 1854 1865 5000
Stack mount 426 410 5000
StackWithIntrinsicChildren mount 852 869 5000
StackWithTextChildren mount 2653 2721 5000
SwatchColorPicker mount 6441 6419 5000
TagPicker mount 1450 1435 5000
Text mount 390 389 5000
TextField mount 928 926 5000
ThemeProvider mount 858 851 5000
ThemeProvider virtual-rerender 585 588 5000
ThemeProvider virtual-rerender-with-unmount 1293 1274 5000
Toggle mount 616 632 5000
buttonNative mount 194 195 5000

fabricteam
fabricteam reviewed Jun 4, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
@Hotell Hotell merged commit 02f620c into microsoft:master Jun 6, 2024
22 checks passed
@Hotell Hotell deleted the repo/license-tweaks branch June 6, 2024 11:24
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
chore: update repo LICENSE (microsoft#31560)
b64258e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@tudorpopams tudorpopams tudorpopams approved these changes

@JustSlone JustSlone JustSlone approved these changes

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

Assignees
No one assigned
Labels
Area: Documentation
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

This repo is missing a LICENSE file
4 participants
@Hotell @fabricteam @JustSlone @tudorpopams