chore: move @fluentui/react-motions-preview to stable #31574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
be54e86
to
1030f8d
Compare
layershifter
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
1030f8d
to
b0e422f
Compare
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jun 5, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 38 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 636 | 637 | 5000 | |
| Button | mount | 320 | 296 | 5000 | |
| Field | mount | 1149 | 1157 | 5000 | |
| FluentProvider | mount | 700 | 703 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 38 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 74 | 10 | |
| MakeStyles | mount | 869 | 876 | 50000 | |
| Persona | mount | 1745 | 1694 | 5000 | |
| SpinButton | mount | 1402 | 1409 | 5000 | |
| SwatchPicker | mount | 1562 | 1594 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AlertMinimalPerf.default | 164 | 165 | 0.99:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| BoxMinimalPerf.default | 210 | 183 | 1.15:1 |
| HeaderMinimalPerf.default | 216 | 199 | 1.09:1 |
| DividerMinimalPerf.default | 203 | 188 | 1.08:1 |
| ButtonMinimalPerf.default | 90 | 84 | 1.07:1 |
| CardMinimalPerf.default | 332 | 309 | 1.07:1 |
| CarouselMinimalPerf.default | 261 | 244 | 1.07:1 |
| PortalMinimalPerf.default | 90 | 84 | 1.07:1 |
| ImageMinimalPerf.default | 231 | 218 | 1.06:1 |
| RosterPerf.default | 1610 | 1525 | 1.06:1 |
| SliderMinimalPerf.default | 768 | 727 | 1.06:1 |
| GridMinimalPerf.default | 198 | 188 | 1.05:1 |
| ListWith60ListItems.default | 385 | 368 | 1.05:1 |
| VideoMinimalPerf.default | 468 | 447 | 1.05:1 |
| AttachmentSlotsPerf.default | 650 | 624 | 1.04:1 |
| ButtonOverridesMissPerf.default | 669 | 642 | 1.04:1 |
| ReactionMinimalPerf.default | 212 | 204 | 1.04:1 |
| ChatWithPopoverPerf.default | 190 | 185 | 1.03:1 |
| DatepickerMinimalPerf.default | 3747 | 3633 | 1.03:1 |
| FlexMinimalPerf.default | 163 | 159 | 1.03:1 |
| MenuButtonMinimalPerf.default | 958 | 931 | 1.03:1 |
| ProviderMergeThemesPerf.default | 655 | 638 | 1.03:1 |
| RefMinimalPerf.default | 115 | 112 | 1.03:1 |
| SkeletonMinimalPerf.default | 205 | 199 | 1.03:1 |
| AvatarMinimalPerf.default | 114 | 112 | 1.02:1 |
| DropdownManyItemsPerf.default | 385 | 379 | 1.02:1 |
| InputMinimalPerf.default | 548 | 535 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 726 | 710 | 1.02:1 |
| TableMinimalPerf.default | 235 | 231 | 1.02:1 |
| ToolbarMinimalPerf.default | 541 | 529 | 1.02:1 |
| AttachmentMinimalPerf.default | 80 | 79 | 1.01:1 |
| ChatMinimalPerf.default | 442 | 437 | 1.01:1 |
| CheckboxMinimalPerf.default | 1143 | 1134 | 1.01:1 |
| DropdownMinimalPerf.default | 1420 | 1403 | 1.01:1 |
| EmbedMinimalPerf.default | 1901 | 1873 | 1.01:1 |
| FormMinimalPerf.default | 226 | 224 | 1.01:1 |
| ListCommonPerf.default | 387 | 384 | 1.01:1 |
| ListMinimalPerf.default | 313 | 309 | 1.01:1 |
| ListNestedPerf.default | 336 | 332 | 1.01:1 |
| MenuMinimalPerf.default | 505 | 499 | 1.01:1 |
| StatusMinimalPerf.default | 393 | 391 | 1.01:1 |
| TableManyItemsPerf.default | 1137 | 1124 | 1.01:1 |
| TreeMinimalPerf.default | 479 | 474 | 1.01:1 |
| AnimationMinimalPerf.default | 293 | 292 | 1:1 |
| PopupMinimalPerf.default | 350 | 350 | 1:1 |
| RadioGroupMinimalPerf.default | 259 | 258 | 1:1 |
| SplitButtonMinimalPerf.default | 2269 | 2266 | 1:1 |
| CustomToolbarPrototype.default | 1451 | 1454 | 1:1 |
| AccordionMinimalPerf.default | 82 | 84 | 0.98:1 |
| ButtonSlotsPerf.default | 299 | 304 | 0.98:1 |
| DialogMinimalPerf.default | 434 | 441 | 0.98:1 |
| LabelMinimalPerf.default | 212 | 216 | 0.98:1 |
| ProviderMinimalPerf.default | 198 | 203 | 0.98:1 |
| TextAreaMinimalPerf.default | 292 | 298 | 0.98:1 |
| TooltipMinimalPerf.default | 1259 | 1280 | 0.98:1 |
| HeaderSlotsPerf.default | 461 | 477 | 0.97:1 |
| IconMinimalPerf.default | 390 | 402 | 0.97:1 |
| LayoutMinimalPerf.default | 188 | 195 | 0.96:1 |
| SegmentMinimalPerf.default | 191 | 198 | 0.96:1 |
| TextMinimalPerf.default | 188 | 195 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 140 | 149 | 0.94:1 |
| TreeWith60ListItems.default | 85 | 92 | 0.92:1 |
| LoaderMinimalPerf.default | 179 | 196 | 0.91:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 628 | 634 | 5000 | |
| Breadcrumb | mount | 1691 | 1688 | 1000 | |
| Checkbox | mount | 1696 | 1705 | 5000 | |
| CheckboxBase | mount | 1475 | 1474 | 5000 | |
| ChoiceGroup | mount | 2946 | 2957 | 5000 | |
| ComboBox | mount | 676 | 725 | 1000 | |
| CommandBar | mount | 6464 | 6510 | 1000 | |
| ContextualMenu | mount | 12492 | 12913 | 1000 | |
| DefaultButton | mount | 805 | 817 | 5000 | |
| DetailsRow | mount | 2194 | 2285 | 5000 | |
| DetailsRowFast | mount | 2220 | 2234 | 5000 | |
| DetailsRowNoStyles | mount | 2034 | 2009 | 5000 | |
| Dialog | mount | 2677 | 2800 | 1000 | |
| DocumentCardTitle | mount | 233 | 237 | 1000 | |
| Dropdown | mount | 1975 | 2034 | 5000 | |
| FocusTrapZone | mount | 1136 | 1147 | 5000 | |
| FocusZone | mount | 1086 | 1078 | 5000 | |
| GroupedList | mount | 42178 | 41852 | 2 | |
| GroupedList | virtual-rerender | 20099 | 20237 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50731 | 51074 | 2 | |
| GroupedListV2 | mount | 227 | 231 | 2 | |
| GroupedListV2 | virtual-rerender | 213 | 215 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 214 | 2 | |
| IconButton | mount | 1139 | 1169 | 5000 | |
| Label | mount | 348 | 353 | 5000 | |
| Layer | mount | 2723 | 2749 | 5000 | |
| Link | mount | 395 | 389 | 5000 | |
| MenuButton | mount | 981 | 997 | 5000 | |
| MessageBar | mount | 21571 | 21556 | 5000 | |
| Nav | mount | 2037 | 2028 | 1000 | |
| OverflowSet | mount | 768 | 785 | 5000 | |
| Panel | mount | 1837 | 1793 | 1000 | |
| Persona | mount | 744 | 794 | 1000 | |
| Pivot | mount | 911 | 896 | 1000 | |
| PrimaryButton | mount | 919 | 935 | 5000 | |
| Rating | mount | 4672 | 4635 | 5000 | |
| SearchBox | mount | 908 | 942 | 5000 | |
| Shimmer | mount | 1900 | 1883 | 5000 | |
| Slider | mount | 1337 | 1329 | 5000 | |
| SpinButton | mount | 3020 | 2969 | 5000 | |
| Spinner | mount | 393 | 393 | 5000 | |
| SplitButton | mount | 1888 | 1904 | 5000 | |
| Stack | mount | 419 | 412 | 5000 | |
| StackWithIntrinsicChildren | mount | 861 | 845 | 5000 | |
| StackWithTextChildren | mount | 2628 | 2676 | 5000 | |
| SwatchColorPicker | mount | 6329 | 6396 | 5000 | |
| TagPicker | mount | 1474 | 1484 | 5000 | |
| Text | mount | 376 | 381 | 5000 | |
| TextField | mount | 937 | 941 | 5000 | |
| ThemeProvider | mount | 843 | 849 | 5000 | |
| ThemeProvider | virtual-rerender | 590 | 580 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1298 | 1300 | 5000 | |
| Toggle | mount | 622 | 611 | 5000 | |
| buttonNative | mount | 202 | 183 | 5000 |
fabricteam
reviewed
Jun 5, 2024
robertpenner
approved these changes
Jun 5, 2024
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
b0e422f
to
ecc5aa9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
ecc5aa9
to
67530cc
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
Jun 5, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Hotell
approved these changes
Jun 6, 2024
YuanboXue-Amber
approved these changes
Jun 6, 2024
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
67530cc
to
8f8591d
Compare
layershifter
force-pushed
the
chore/move-motions-stable
branch
from
8f8591d
to
69348a7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ling1726
approved these changes
Jun 6, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
@fluentui/react-motions-previewis unstable.New Behavior
@fluentui/react-motions-previewis moved to stable as@fluentui/react-motion.Notes
PresenceGroupto not use#privatemodifiers as it's out of our TS min bar.