Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-tags): Adds disabled property to TagGroup #32317

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

emmayjiang
Copy link
Contributor

Previous Behavior

TagGroup could not be disabled, causing some a11y checkers to be flagging it for contrast issues.

New Behavior

TagGroup can now be disabled, and it disables all tags within it.

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 15, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.097 MB
271.028 kB
1.097 MB
271.076 kB
164 B
48 B
react-tag-picker
@fluentui/react-tag-picker - package
182.176 kB
54.779 kB
182.276 kB
54.803 kB
100 B
24 B
react-tags
InteractionTag
15.167 kB
6.141 kB
15.199 kB
6.157 kB
32 B
16 B
react-tags
Tag
28.995 kB
9.519 kB
29.027 kB
9.528 kB
32 B
9 B
react-tags
TagGroup
82.13 kB
24.342 kB
82.197 kB
24.362 kB
67 B
20 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.14 kB
20.137 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
218.197 kB
63.203 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.387 kB
35.758 kB
🤖 This report was generated against c12f81a1e4d73361114d1264d86421b8d88b7045

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 15, 2024

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 39 43 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 653 643 5000
Button mount 308 316 5000
Field mount 1170 1121 5000
FluentProvider mount 728 708 5000
FluentProviderWithTheme mount 86 90 10
FluentProviderWithTheme virtual-rerender 39 43 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 78 83 10
MakeStyles mount 871 866 50000
Persona mount 1795 1711 5000
SpinButton mount 1410 1400 5000
SwatchPicker mount 1683 1647 5000

@emmayjiang emmayjiang marked this pull request as ready for review August 15, 2024 16:59
@emmayjiang emmayjiang requested review from a team as code owners August 15, 2024 16:59
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be a good idea to also update the TagPicker's disabled story to use disabled on the TagGroup instead of individual tags.

After that, this looks good to me!

@smhigley smhigley merged commit 0a88822 into microsoft:master Aug 19, 2024
19 checks passed
@smhigley smhigley deleted the react-tags-disableable-group branch August 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants