-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-tags): Adds disabled property to TagGroup #32317
Merged
smhigley
merged 13 commits into
microsoft:master
from
emmayjiang:react-tags-disableable-group
Aug 19, 2024
Merged
feat(react-tags): Adds disabled property to TagGroup #32317
smhigley
merged 13 commits into
microsoft:master
from
emmayjiang:react-tags-disableable-group
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 39 | 43 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 653 | 643 | 5000 | |
Button | mount | 308 | 316 | 5000 | |
Field | mount | 1170 | 1121 | 5000 | |
FluentProvider | mount | 728 | 708 | 5000 | |
FluentProviderWithTheme | mount | 86 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender | 39 | 43 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 83 | 10 | |
MakeStyles | mount | 871 | 866 | 50000 | |
Persona | mount | 1795 | 1711 | 5000 | |
SpinButton | mount | 1410 | 1400 | 5000 | |
SwatchPicker | mount | 1683 | 1647 | 5000 |
fabricteam
reviewed
Aug 15, 2024
change/@fluentui-react-tag-picker-9be006cd-1c03-46c8-a255-b35dd8971bee.json
Show resolved
Hide resolved
smhigley
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be a good idea to also update the TagPicker's disabled story to use disabled
on the TagGroup instead of individual tags.
After that, this looks good to me!
...ages/react-components/react-tags/library/src/components/InteractionTag/useInteractionTag.tsx
Outdated
Show resolved
Hide resolved
smhigley
approved these changes
Aug 16, 2024
YuanboXue-Amber
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
TagGroup could not be disabled, causing some a11y checkers to be flagging it for contrast issues.
New Behavior
TagGroup can now be disabled, and it disables all tags within it.
Related Issue(s)