Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TableHeaderCell): should use hover and pressed tokens #32352

Merged

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Aug 21, 2024

Adds

  • colorNeutralForegroundHover
  • colorNeutralForeground1Pressed

For hover/pressed states respectively to fix high contrast issues

Before
image

After
image

Fixes #32301

Adds
* `colorNeutralForegroundHover`
* `colorNeutralForeground1Pressed`

For hover/pressed states respectively to fix high contrast issues

Fixes microsoft#32301
@ling1726 ling1726 requested a review from a team as a code owner August 21, 2024 10:00
@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 21, 2024
@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.097 MB
271.073 kB
1.097 MB
271.096 kB
162 B
23 B
react-table
DataGrid
160.296 kB
45.518 kB
160.458 kB
45.536 kB
162 B
18 B
react-table
Table (Primitives only)
42.481 kB
13.802 kB
42.643 kB
13.82 kB
162 B
18 B
react-table
Table as DataGrid
131.15 kB
36.354 kB
131.312 kB
36.37 kB
162 B
16 B
react-table
Table (Selection only)
70.337 kB
19.943 kB
70.499 kB
19.962 kB
162 B
19 B
react-table
Table (Sort only)
68.98 kB
19.555 kB
69.142 kB
19.573 kB
162 B
18 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.14 kB
20.137 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
218.197 kB
63.203 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.387 kB
35.758 kB
🤖 This report was generated against 843386fc13e12d9efca29eb1e26a2654239167b6

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 42 37 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 636 656 5000
Button mount 318 312 5000
Field mount 1163 1145 5000
FluentProvider mount 737 738 5000
FluentProviderWithTheme mount 91 91 10
FluentProviderWithTheme virtual-rerender 42 37 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 83 93 10
MakeStyles mount 877 858 50000
Persona mount 1779 1729 5000
SpinButton mount 1457 1445 5000
SwatchPicker mount 1709 1723 5000

@ling1726 ling1726 merged commit d3249d6 into microsoft:master Aug 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: sortable header cell does not have sufficient contrast on hover
3 participants