Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace-plugin): implement type-check executor #32370

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 23, 2024

Previous Behavior

New Behavior

💡 What is nx executor ? https://nx.dev/concepts/executors-and-configurations

  • implements type-check executor
  • replaces npm script type-check within workspace-plugin with new executor
    • in future we should switch to programatic API for invoking tsc ( public API is already available from @nx/js package ). In order to make this a "1:1" replacement to existing just-scripts, executor uses exec to invoke tsc from shell directly.
    • enables executor for workspace-plugin project

Related Issue(s)

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 23, 2024
@Hotell Hotell changed the title Nx/workspace plugin/type check executor feat(workspace-plugin): implement type-check executor Aug 23, 2024
@Hotell Hotell mentioned this pull request Aug 23, 2024
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2024

📊 Bundle size report

✅ No changes found

@Hotell Hotell marked this pull request as ready for review August 26, 2024 13:55
@Hotell Hotell requested a review from a team as a code owner August 26, 2024 13:55
@Hotell Hotell merged commit b733c23 into microsoft:master Aug 28, 2024
20 checks passed
@Hotell Hotell deleted the nx/workspace-plugin/type-check-executor branch August 28, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants