Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (react-dialog): Use consistent rounding for clientHeight and innerHeight #32480

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix (react-dialog): Use consistent rounding for clientHeight and innerHeight #32480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d391c70
Round clientHeight down to match innerHeight calculation.
CampbellOwen Sep 6, 2024
05f69a7
Add change file
CampbellOwen Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-dialog-a4232c34-ea7b-4222-a164-74574abfa9e1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Adjust window height comparison in fractional cases.",
"packageName": "@fluentui/react-dialog",
"email": "owcampbe@microsoft.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/react-components/react-dialog/library/src/utils/useDisableBodyScroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export function useDisableBodyScroll(): {
return;
}
const isHorizontalScrollbarVisible =
targetDocument.body.clientHeight > (targetDocument.defaultView?.innerHeight ?? 0);
// When the window is a fractional height, `innerHeight` always rounds down but `clientHeight` rounds either up or down depending on the value.
// To properly compare the body clientHeight to the window innerHeight, manually round down the fractional value to match innerHeight's calculation.
Math.floor(targetDocument.body.getBoundingClientRect().height) > (targetDocument.defaultView?.innerHeight ?? 0);
micahgodbolt marked this conversation as resolved.
Show resolved Hide resolved
if (!isHorizontalScrollbarVisible) {
return;
}
Expand Down
Loading