-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-drawer): apply position: absolute when mountNode is passed #32816
Merged
marcosmoura
merged 6 commits into
microsoft:master
from
marcosmoura:fix/react-drawer/drawer-as-position-absolute
Sep 11, 2024
Merged
fix(react-drawer): apply position: absolute when mountNode is passed #32816
marcosmoura
merged 6 commits into
microsoft:master
from
marcosmoura:fix/react-drawer/drawer-as-position-absolute
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
added
Fluent UI react-components (v9)
Component: Drawer
The Fluent v9 Drawer component
labels
Sep 11, 2024
2 tasks
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 609 | 619 | 5000 | |
Button | mount | 301 | 312 | 5000 | |
Field | mount | 1148 | 1152 | 5000 | |
FluentProvider | mount | 717 | 730 | 5000 | |
FluentProviderWithTheme | mount | 88 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 81 | 10 | |
MakeStyles | mount | 871 | 866 | 50000 | |
Persona | mount | 1756 | 1748 | 5000 | |
SpinButton | mount | 1401 | 1361 | 5000 | |
SwatchPicker | mount | 1629 | 1701 | 5000 |
fabricteam
reviewed
Sep 11, 2024
mainframev
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few small suggestions
...omponents/react-drawer/library/src/components/OverlayDrawer/useOverlayDrawerStyles.styles.ts
Outdated
Show resolved
Hide resolved
...omponents/react-drawer/library/src/components/OverlayDrawer/useOverlayDrawerStyles.styles.ts
Outdated
Show resolved
Hide resolved
...omponents/react-drawer/library/src/components/OverlayDrawer/useOverlayDrawerStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-drawer/stories/src/Drawer/OverlayInsideContainer.stories.tsx
Outdated
Show resolved
Hide resolved
…layInsideContainer.stories.tsx Co-authored-by: Victor Genaev <vgenaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Drawer would always render using
position: fixed
, to be displayed as a root element.New Behavior
In case
mountNode
is passed, Drawer will now render asposition: absolute
to be contained in the target element.Related Issue(s)