Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace-plugin): prepare-initial-release - phase:stable - update additional files and properly resolve *-stories package.json definitions #32892

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 23, 2024

Previous Behavior

New Behavior

  • See PR title + referenced issue
  • ci: adds prepare-initial-release test suite to run cross platform as part of our tooling pipeline, to verify proper path resolution cross platform
  • feat: replace *-preview occurences within all library sources ( eg console.warn('@fluent/foo-preview: this is wrong') --> console.warn('@fluent/foo: this is wrong')

Related Issue(s)

…e additional files and properly resolve *-stories package.json definitions
@Hotell Hotell changed the title fix(workspace-plugin): prepare-initial-release - phase:stable - updat… fix(workspace-plugin): prepare-initial-release - phase:stable - update additional files and properly resolve *-stories package.json definitions Sep 23, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 23, 2024

📊 Bundle size report

✅ No changes found

@Hotell Hotell marked this pull request as ready for review September 24, 2024 08:46
@Hotell Hotell requested a review from a team as a code owner September 24, 2024 08:46
@Hotell Hotell merged commit cadd3dc into microsoft:master Sep 24, 2024
20 checks passed
@Hotell Hotell deleted the workspace/plugin/generators/fix-prepare-initial-release branch September 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: prepare-initial-release issues
3 participants