Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rush 5 #6242

Merged
merged 28 commits into from
Sep 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0bf0ab8
Upgrade config files to Rush 5 syntax
pgonzal Aug 22, 2018
b735fb5
rush update
pgonzal Aug 22, 2018
b01b9d6
Start updating scripts to avoid a phantom node_modules folder in the …
pgonzal Aug 22, 2018
5065264
Merge branch 'master' into pgonzal/upgrade-to-rush-5
natalieethell Sep 5, 2018
71cf38d
update rush version
natalieethell Sep 6, 2018
9ead827
update lint-staged to ignore common/scripts
natalieethell Sep 6, 2018
c48e710
add hooks
natalieethell Sep 6, 2018
e43a514
Merge branch 'master' into pgonzal/upgrade-to-rush-5
natalieethell Sep 6, 2018
a209403
update shrinkwrap
natalieethell Sep 6, 2018
c65703b
update snapshots
natalieethell Sep 6, 2018
79caefb
update experiments snapshot
natalieethell Sep 6, 2018
44e4e2e
change files
natalieethell Sep 6, 2018
697a844
Merge branch 'master' into pgonzal/upgrade-to-rush-5
natalieethell Sep 7, 2018
ca9fff2
update snapshots
natalieethell Sep 7, 2018
cf616d5
add tslib as a dependency in dashboard
natalieethell Sep 7, 2018
cbd57d9
dashboard change file
natalieethell Sep 7, 2018
40400cb
Merge branch 'master' into pgonzal/upgrade-to-rush-5
natalieethell Sep 11, 2018
042c57e
update DatePicker snapshots
natalieethell Sep 11, 2018
90915a7
add apps/vr-tests/** to ignore of lint-staged
natalieethell Sep 11, 2018
8a8e94c
add newline
natalieethell Sep 11, 2018
ba639d4
should be rush update --full instead of --force
natalieethell Sep 12, 2018
9ffee7a
generate runs with full and update runs without full
natalieethell Sep 12, 2018
1e82127
change type to none for upgrading react-test-renderer
natalieethell Sep 12, 2018
7990b80
add newline to package.json
natalieethell Sep 12, 2018
28a5c76
update to rush-update
natalieethell Sep 12, 2018
abaf16c
Merge branch 'master' into pgonzal/upgrade-to-rush-5
natalieethell Sep 12, 2018
37402d9
update SpinButton snapshot to remove undefined
natalieethell Sep 12, 2018
4324708
change file for prettier fixes in fabric-website
natalieethell Sep 12, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ language: node_js
node_js:
- '8'
script:
- node common/scripts/install-run-rush.js install --bypass-policy
- if [ $TRAVIS_BRANCH == "master" ] && [ $TRAVIS_PULL_REQUEST != "false" ];
then npm run checkchange;
fi
Expand Down
149 changes: 64 additions & 85 deletions apps/fabric-website/src/pages/GetStarted/GetStartedPage.tsx

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/dashboard",
"comment": "add tslib as a dependency in dashboard",
"type": "patch"
}
],
"packageName": "@uifabric/dashboard",
"email": "natalie.ethell@microsoft.com"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "react-test-renderer version updated 16.4.2 -> 16.5.0",
"type": "none"
}
],
"packageName": "@uifabric/experiments",
"email": "natalie.ethell@microsoft.com"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/fabric-website",
"comment": "prettier fixes",
"type": "patch"
}
],
"packageName": "@uifabric/fabric-website",
"email": "naethell@microsoft.com"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "react-test-renderer version updated 16.4.2 -> 16.5.0",
"type": "none"
}
],
"packageName": "office-ui-fabric-react",
"email": "natalie.ethell@microsoft.com"
}
44 changes: 29 additions & 15 deletions common/config/rush/command-line.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,41 @@
{
"customCommands": [
"$schema": "https://developer.microsoft.com/json-schemas/rush/v5/command-line.schema.json",
"commands": [
{
"name": "code-style",
"summary": "Runs prettier and tslint.",
"documentation": "Runs prettier and tslint for each of the packages that have a code-style task.",
"parallelized": true
"commandKind": "bulk",
"description": "Runs prettier and tslint for each of the packages that have a code-style task.",
"enableParallelism": true
}
],
"customOptions": {
"--production": {
"optionType": "flag",
"parameters": [
{
"longName": "--production",
"parameterKind": "flag",
"description": "Builds production bits.",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
},
"--lint": {
"optionType": "flag",
{
"longName": "--lint",
"parameterKind": "flag",
"description": "Builds with linting.",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
},
"--npm-install-mode": {
"optionType": "flag",
{
"longName": "--npm-install-mode",
"parameterKind": "flag",
"description": "Skips tasks that are irrelevant during npm install",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
}
}
}
]
}
8 changes: 8 additions & 0 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/rush/v5/common-versions.schema.json",
"preferredVersions": {
"webpack": "3.11.0",
"webpack-dev-server": "2.11.2",
"webpack-cli": "2.0.15"
}
}
Loading