fix(stdio): drain stdio before process.exit #244

dgozman · 2021-04-23T02:49:31Z

process.exit() may not flush stdio, which in turn can lead to the loss of output.
See nodejs/node#6456.

This issue manifests with max-failures should work test being flaky,
where we examine large output and it is sometimes truncated.

`process.exit()` may not flush stdio, which in turn can lead to the loss of output. See nodejs/node#6456. This issue manifests with `max-failures should work` test being flaky, where we examine large output and it is sometimes truncated.

fix(stdio): drain stdio before process.exit

a1c64f7

`process.exit()` may not flush stdio, which in turn can lead to the loss of output. See nodejs/node#6456. This issue manifests with `max-failures should work` test being flaky, where we examine large output and it is sometimes truncated.

aslushnikov approved these changes Apr 23, 2021

View reviewed changes

dgozman merged commit e218b2d into microsoft:master Apr 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(stdio): drain stdio before process.exit #244

fix(stdio): drain stdio before process.exit #244

dgozman commented Apr 23, 2021

fix(stdio): drain stdio before process.exit #244

fix(stdio): drain stdio before process.exit #244

Conversation

dgozman commented Apr 23, 2021