LINSERT ignores lower case 'before'

[prvyk]

Describe the bug

rpush mylist 0",
rpush mylist 2",
linsert mylist before 2 1
lrange mylist 0 -1

Result:
0 2 1

This is because ListObjectImpl.cs:95 only compares against uppercase CmdStrings.BEFORE .

( One could add the lower case version, but if the choice is to allow input like 'LInsert mylist aGter 0 1' in order to optimize, perhaps the better way would be to only compare the first character against 'B' or 'b', or even '((ushort)char & 1) != 1' ? ).

---

Was found by running

https://github.com/tair-opensource/resp-compatibility/

and inspecting the testcase failure.

Steps to reproduce the bug

rpush mylist 0",
rpush mylist 2",
linsert mylist before 2 1
lrange mylist 0 -1

Expected behavior

0 1 2

Screenshots

No response

Release version

v1.0.52

IDE

No response

OS version

No response

Additional context

No response

[badrishc]

Good catch. We should probably make it:

var insertBefore = position.EqualsUpperCaseSpanIgnoringCase(CmdStrings.BEFORE);

[Vijay-Nirmal]

@prvyk Can you raise a PR to fix this if possible?