Add ZMSCORE command support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Make sure you use the error handling logic introduced in this recent PR: #103 |
I believe I am using the newly introduced command, however I have improved the count check and removed the arithmetic to be inline with the changes in the referenced PR. |
TalZaccai
requested changes
Mar 26, 2024
|
Cheers, that was a very good review😅 I believe I have addressed all the issues less some potential clarification in the unresolved review convos. |
TalZaccai
approved these changes
Mar 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried my hand at adding the
ZMSCOREcommand using the(very helpful) direction in the issue and surrounding code.The score/scores fetching implementations could likely be merged.
resolves #77