Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the subscriber when unsubscribe #144

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

hez2010
Copy link
Contributor

@hez2010 hez2010 commented Mar 26, 2024

Fix the issue where unsubscribe doesn't remove the subscriber.
This can cause ObjectDisposedException later if the publisher publishes a new message after a subscriber unsubscribed and disconnected from the server.

@hez2010
Copy link
Contributor Author

hez2010 commented Mar 27, 2024

To reproduce the bug:

  1. Run RedisInsight, goto the Sub/Pub page
  2. Subscribe and publish some messages
  3. Unsubscribe and then continue to publish some messages
  4. See exception from the server

@badrishc
Copy link
Contributor

LGTM, thanks!

@badrishc badrishc merged commit f7b6e08 into microsoft:main Mar 27, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants