Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start offset test in LRANGE #222

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Apr 2, 2024

relation #210

@TalZaccai TalZaccai requested a review from badrishc April 2, 2024 18:42
@badrishc
Copy link
Contributor

badrishc commented Apr 3, 2024

Add test case for this scenario:

redis> RPUSH mylist "one"
(integer) 1
redis> RPUSH mylist "two"
(integer) 2
redis> RPUSH mylist "three"
(integer) 3
redis> LRANGE mylist 0 0
1) "one"
redis> LRANGE mylist -3 2
1) "one"
2) "two"
3) "three"
redis> LRANGE mylist -100 100
1) "one"
2) "two"
3) "three"
redis> LRANGE mylist 5 10
(empty array)

@badrishc badrishc self-assigned this Apr 3, 2024
@badrishc badrishc merged commit 0b34387 into microsoft:main Apr 3, 2024
21 checks passed
@tisilent tisilent deleted the add-LRANGE-startoffset-test branch April 4, 2024 05:25
altall pushed a commit to altall/garnet that referenced this pull request Apr 5, 2024
* add start offset test in LRANGE

* whitespace formatting.

* add LRANGE basic test case

---------

Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants