Bugfix: Limit Basic Commands to Authenticated Users #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical bug related to permissions checking during the processing of basic commands, where some RESP commands could be executed by unauthenticated users. Unauthenticated users should only be allowed to execute the AUTH command.
Bug Description
Steps to Reproduce
Start Garnet with password authentication enabled:
Connect to Garnet without authenticating and issue a common command other than AUTH (e.g. PING, GET or SET):
Expected Result
Actual Result
Commands that are part of the basic command group are executed even when the client is not authenticated.
Changes
To fix this issue, the following changes have been made: