Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SRANDMEMBER command #240

Merged
merged 12 commits into from
Apr 12, 2024
Merged

feat: add SRANDMEMBER command #240

merged 12 commits into from
Apr 12, 2024

Conversation

Zzhiter
Copy link
Contributor

@Zzhiter Zzhiter commented Apr 5, 2024

@TalZaccai TalZaccai linked an issue Apr 6, 2024 that may be closed by this pull request
API Coverage - Implement SRANDMEMBER #231
Closed
@TalZaccai TalZaccai self-requested a review April 6, 2024 03:06
@TalZaccai TalZaccai self-assigned this Apr 6, 2024
TalZaccai
TalZaccai requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Added some comments mainly concerning runtime optimizations.

libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandsInfo.cs Outdated Show resolved Hide resolved
TalZaccai
TalZaccai requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small comments :)

libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/Set/SetObjectImpl.cs Outdated Show resolved Hide resolved
@TalZaccai TalZaccai added the API label Apr 12, 2024
@TalZaccai TalZaccai merged commit c745364 into microsoft:main Apr 12, 2024
21 checks passed
@TalZaccai TalZaccai mentioned this pull request Apr 23, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees

@TalZaccai TalZaccai

Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Coverage - Implement SRANDMEMBER
2 participants
@Zzhiter @TalZaccai