Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAILOVER replica attach workflow #293

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

vazois
Copy link
Contributor

@vazois vazois commented Apr 19, 2024

This PR refactors the failover workflow logic to deal with the following issues:

  1. Attaching to many replicas some of which are unreachable. In main this would have caused the attach loop to fail and result in some of the reachable replicas never receiving the attach message.
  2. When FAILOVER with default option is called the old primary will receive a request to become a replica as per the Redis spec.
  3. Added flag to useGossipConnections for the failover but did not currently expose it until requested.

@vazois vazois linked an issue Apr 19, 2024 that may be closed by this pull request
@vazois vazois linked an issue Apr 19, 2024 that may be closed by this pull request
@TalZaccai TalZaccai requested a review from badrishc April 23, 2024 18:37
Copy link
Contributor

@badrishc badrishc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve conflicts and merge, thanks!

@vazois vazois merged commit 47da479 into microsoft:main Apr 24, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@vazois vazois deleted the vazois/fix-failover branch September 17, 2024 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replicas not attaching correctly on failover
2 participants